Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf(py314): Replace deprecated pkgutil.find_loader #828

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

effigies
Copy link
Contributor

This PR removes pkgutil.find_loader() and replaces it with importlib.util.find_spec(). find_loader was deprecated in Python 3.12 and will be removed in 3.14. find_spec has been present since Python 3.4.

Both functions return None if the module loader cannot be found. For its use in this project, this is sufficient and no translation of the return value is needed.

Copy link

welcome bot commented Oct 16, 2024

Thanks for opening this pull request! We have detected this is the first time for you to contribute to qsiprep. Please check out our contributing guidelines.
These are guidelines intended to make communication easier by describing a consistent process, but don't worry if you don't get it everything exactly "right" on the first try.
We invite you to list yourself as a qsiprep contributor, so if your name is not already mentioned, please modify the .zenodo.json file with your data. If you do so, your name will be listed as an author at the next release. Please add yourself to the list in alphabetical order, keeping Cieslak, Matthew as first and Satterthwaite, Theodore D. as last authors, e.g.:

  {
    (...)
  },
  {
   {
      "name": "<LastName>, <FirstName>",
      "affiliation": "<Affiliation>",
      "orcid": "<Id>"
   },
  {
    (...)
  }
], "keywords": [
  "neuroimaging",
  "workflow",
  "pipeline",
  "preprocessing",
  "dMRI",
  "BIDS"
], (...) ```
Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.13%. Comparing base (2967323) to head (9f48b2e).

Files with missing lines Patch % Lines
qsiprep/cli/parser.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   28.13%   28.13%           
=======================================
  Files          69       69           
  Lines       10080    10080           
  Branches     1107     1106    -1     
=======================================
  Hits         2836     2836           
  Misses       7146     7146           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattcieslak mattcieslak merged commit 551bacd into PennLINC:master Oct 25, 2024
20 checks passed
@mattcieslak
Copy link
Collaborator

Thank you @effigies!!

@effigies effigies deleted the rf/drop-pkgutil-find_loader branch October 25, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants