Use nireports for HTML reports #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should move the interactive report workflows into a recon workflow instead of in reports |
|
Ah okay. I can drop it and just modify the expected outputs. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 28.59% 28.21% -0.38%
==========================================
Files 69 69
Lines 10218 10040 -178
Branches 1331 1299 -32
==========================================
- Hits 2922 2833 -89
+ Misses 7195 7111 -84
+ Partials 101 96 -5 ☔ View full report in Codecov by Sentry. |
mattcieslak
approved these changes
Aug 22, 2024
| # session_list = ( | ||
| # config.execution.get().get('bids_filters', {}).get('dwi', {}).get('session') | ||
| # ) | ||
| session_list = config.execution.get().get("bids_filters", {}).get("dwi", {}).get("session") |
There was a problem hiding this comment.
this is some interesting syntax
| @@ -433,6 +433,7 @@ class execution(_Config): | |||
| """Write out the computational graph corresponding to the planned preprocessing.""" | |||
| dataset_links = {} | |||
| """A dictionary of dataset links to be used to track Sources in sidecars.""" | |||
| aggr_ses_reports = 4 | |||
There was a problem hiding this comment.
Yeah it should work with this PR. We can add a command-line parameter for it as well.
|
Unfortunately not yet. We need to follow up with nireports to support gifs. |
|
I've opened a PR to support GIFs in nipreps/nireports#128. |
tsalo
added
the
refactor
mattcieslak
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #805.
Changes proposed in this pull request
Documentation that should be reviewed