-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nireports for HTML reports #808
Conversation
I think we should move the interactive report workflows into a recon workflow instead of in reports |
Ah okay. I can drop it and just modify the expected outputs. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 28.59% 28.21% -0.38%
==========================================
Files 69 69
Lines 10218 10040 -178
Branches 1331 1299 -32
==========================================
- Hits 2922 2833 -89
+ Misses 7195 7111 -84
+ Partials 101 96 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this nireports release support gifs?
# session_list = ( | ||
# config.execution.get().get('bids_filters', {}).get('dwi', {}).get('session') | ||
# ) | ||
session_list = config.execution.get().get("bids_filters", {}).get("dwi", {}).get("session") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is some interesting syntax
@@ -433,6 +433,7 @@ class execution(_Config): | |||
"""Write out the computational graph corresponding to the planned preprocessing.""" | |||
dataset_links = {} | |||
"""A dictionary of dataset links to be used to track Sources in sidecars.""" | |||
aggr_ses_reports = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this work now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it should work with this PR. We can add a command-line parameter for it as well.
Unfortunately not yet. We need to follow up with nireports to support gifs. |
I've opened a PR to support GIFs in nipreps/nireports#128. |
Closes #805.
Changes proposed in this pull request
Documentation that should be reviewed