Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop mentions of the qsiprep-docker wrapper #807

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Drop mentions of the qsiprep-docker wrapper #807

merged 2 commits into from
Aug 23, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 16, 2024

Closes none.

Changes proposed in this pull request

  • Drop mentions of the qsiprep-docker wrapper

@tsalo tsalo added the breaking-change Issues/PRs that change results or interfaces. label Aug 16, 2024
@tsalo tsalo requested a review from mattcieslak August 16, 2024 20:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.58%. Comparing base (6decb38) to head (842f368).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
- Coverage   28.59%   28.58%   -0.01%     
==========================================
  Files          69       69              
  Lines       10218    10217       -1     
  Branches     1331     1331              
==========================================
- Hits         2922     2921       -1     
  Misses       7195     7195              
  Partials      101      101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Aug 23, 2024

@mattcieslak I think we need to merge this one in to get the Docker image deploying again. Could you take a look when you get a chance?

Copy link
Collaborator

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the docker command you don't need to specify qsiprep anywhere in there if you're doing a docker run. Otherwise all good!

docs/contributors.rst Outdated Show resolved Hide resolved
@tsalo tsalo merged commit 1e5ca04 into master Aug 23, 2024
20 checks passed
@tsalo tsalo deleted the drop-wrapper branch August 23, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Issues/PRs that change results or interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants