Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FUGUE bug #769

Merged
merged 26 commits into from
Jul 12, 2024
Merged

Fix FUGUE bug #769

merged 26 commits into from
Jul 12, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 8, 2024

Closes #752.

Changes proposed in this pull request

NOTE: I had to downsample the anatomical scans from both datasets to 2 mm3 and set the resource class to xlarge to get SynthSeg to run without getting killed.

@tsalo tsalo added bug Something isn't working testing labels Jul 8, 2024
@tsalo
Copy link
Member Author

tsalo commented Jul 8, 2024

Both new tests succeed, but neither produces any outputs. @mattcieslak any clue what's wrong?

EDIT: It was because I included --boilerplate in the commands.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 17.02128% with 78 lines in your changes missing coverage. Please review.

Project coverage is 29.83%. Comparing base (65791db) to head (ea86bf8).
Report is 1 commits behind head on master.

Files Patch % Lines
qsiprep/interfaces/niworkflows.py 16.30% 77 Missing ⚠️
qsiprep/workflows/fieldmap/unwarp.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage   29.77%   29.83%   +0.06%     
==========================================
  Files          97       97              
  Lines       14583    14674      +91     
  Branches     1886     1899      +13     
==========================================
+ Hits         4342     4378      +36     
- Misses      10115    10168      +53     
- Partials      126      128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo requested a review from mattcieslak July 9, 2024 17:59
@tsalo
Copy link
Member Author

tsalo commented Jul 9, 2024

@mattcieslak it's working! Can you review when you have some time?

@tsalo tsalo merged commit dfd0ab2 into PennLINC:master Jul 12, 2024
34 checks passed
@tsalo tsalo deleted the fix-fugue-bug branch July 12, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using FUGUE for fieldmap (after removing niworkflows)
3 participants