Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary dependencies #325

Merged
merged 10 commits into from
Sep 27, 2023
Merged

Remove unnecessary dependencies #325

merged 10 commits into from
Sep 27, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 26, 2023 •
edited
Loading

Closes none.

Changes proposed in this pull request

  • Remove unused dependencies (nitime and pyslim).
    • It turns out nipype's confounds functions require nitime, so I added the nipy dependency group to the nipype install.
  • Remove flake8-warnings from linting job dependencies.
  • Bump Python version from 3.8 to 3.9.

@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label Sep 26, 2023
@tsalo tsalo self-assigned this Sep 26, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
aslprep/config.py 83.51% <100.00%> (+0.23%) ⬆️
aslprep/workflows/base.py 83.95% <ø> (ø)
aslprep/utils/asl.py 70.00% <50.00%> (-1.93%) ⬇️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@tsalo tsalo merged commit 9437ba8 into PennLINC:main Sep 27, 2023
20 checks passed
@tsalo tsalo deleted the rm-dependencies branch September 27, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tsalo tsalo

Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsalo @codecov-commenter