Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sdcflows calls with dependency calls #219

Closed
wants to merge 14 commits into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 23, 2023

Closes None, but works toward #199.

I think the adapted version is from 1.3.3.

The elements from sdcflows that aslprep uses are:

  • fieldmap_wrangler
  • init_sdc_estimate_wf
  • init_sdc_unwarp_report_wf

Unfortunately, sdcflows has changed considerably since the code was copied into aslprep, and fmriprep's field map handling is really complex.

Changes proposed in this pull request

Documentation that should be reviewed

I think the adapted version is from 1.3.3.
@tsalo tsalo added refactor Changes to the codebase that don't impact workflow inputs or outputs. maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. labels Feb 23, 2023
@tsalo
Copy link
Member Author

tsalo commented Feb 23, 2023

I think the sdcflows and niworkflows versions conflict, since the failure happens within sdcflows.

@tsalo tsalo marked this pull request as draft February 23, 2023 15:04
@tsalo
Copy link
Member Author

tsalo commented Dec 6, 2023

Closing in favor of #338.

@tsalo tsalo closed this Dec 6, 2023
@tsalo tsalo deleted the remove-sdcflows branch December 12, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant