Izuma branding, PR checks, go 1.18 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanneKiiskila
commented
Jan 24, 2023
•
JanneKiiskila
commented
- PR checks.
- Izuma / PelionIoT domain change.
- go update to version 1.18.
- shellcheck fixes to scripts in hack-folder.
ArmMbedEdge changed to PelionIoT. Update go to version 18. Remote Godeps, move to go.mod based module management.
As go get will not pass yet, it is commented out.
Add script for running golint on all modules.
Use go_vet_script etc. from scripts-internal.
JanneKiiskila
force-pushed
the
izuma-branding
branch
from
6c14438 to
36215c4
Compare
petedyer11
suggested changes
Jan 25, 2023
|
|
||
| // | ||
| // Copyright (c) 2019 ARM Limited. |
There was a problem hiding this comment.
If we are changing this file shouldn't we also add an Izuma line here?
|
|
||
| // | ||
| // Copyright (c) 2019 ARM Limited. |
| ) | ||
|
|
||
| require ( | ||
| github.com/armPelionEdge/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e // indirect |
There was a problem hiding this comment.
Suggested change
| github.com/armPelionEdge/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e // indirect | |
| github.com/PelionIoT/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e // indirect |
Comment on lines
+3
to
+4
| github.com/armPelionEdge/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e h1:DigWoM3xSx/R38Vm2YTG38cnEx8d0xbNnEht8QltKGw= | ||
| github.com/armPelionEdge/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e/go.mod h1:9sZEdJAnZqxcxmB/vpnI71RoC4xps9tveHhsPKj21k0= |
There was a problem hiding this comment.
Suggested change
| github.com/armPelionEdge/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e h1:DigWoM3xSx/R38Vm2YTG38cnEx8d0xbNnEht8QltKGw= | |
| github.com/armPelionEdge/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e/go.mod h1:9sZEdJAnZqxcxmB/vpnI71RoC4xps9tveHhsPKj21k0= | |
| github.com/PelionIoT/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e h1:DigWoM3xSx/R38Vm2YTG38cnEx8d0xbNnEht8QltKGw= | |
| github.com/PelionIoT/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e/go.mod h1:9sZEdJAnZqxcxmB/vpnI71RoC4xps9tveHhsPKj21k0= |
There was a problem hiding this comment.
This file gets autogenerated, so need to get the wigwag-go-logger PR merged in 1st.
PelionIoT/wigwag-go-logger#2
Comment on lines
+3
to
+4
| github.com/PelionIoT/wigwag-go-logger/logging | ||
| # github.com/armPelionEdge/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e |
There was a problem hiding this comment.
Suggested change
| github.com/PelionIoT/wigwag-go-logger/logging | |
| # github.com/armPelionEdge/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e | |
| github.com/PelionIoT/wigwag-go-logger/logging | |
| # github.com/PelionIoT/wigwag-go-logger v0.0.0-20230118193751-0f87f851cf9e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.