Collin/update prost build #307
Conversation
cbrit
force-pushed
the
collin/update-prost-build
branch
from
5aa0439 to
882163d
Compare
WalkthroughThis update introduces several enhancements to the Rust Proto Bindings Build process, including new type attributes for serialization, the addition of new fields in specific structs, and the incorporation of third-party protobufs. Notable changes include the need for manual Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (18)
Files skipped from review due to trivial changes (4)
Additional context usedLanguageTool
Additional comments not posted (19)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (1)
prost_build/README.md (1)
5-5: Theserdeattributes are not manually added to theCellarIdSettype.The
serde::Deserializeandserde::Serializeattributes are not found in theCellarIdSetstruct definitions within the generated files. Although there is a.type_attributecall inprost_build/src/main.rsto add these attributes, it does not appear to be effective.
somm_proto/src/prost/axelarcork.v1.rssomm_proto/src/prost/cork.v2.rsAnalysis chain
Verify the manual addition of
serdeattributes.Ensure that the
serde::Deserializeandserde::Serializeattributes are manually added to theCellarIdSettype after runningprost_build.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the manual addition of `serde` attributes to `CellarIdSet`. # Test: Search for the `CellarIdSet` type in the generated files. Expect: `serde` attributes to be present. rg --type rust 'CellarIdSet' -A 5Length of output: 4993
Tools
LanguageTool
[duplication] ~5-~5: Possible typo: you repeated a word
Context: ...attributeconfig method is not working the theCellarIdSet` type, therefore whenever ...(ENGLISH_WORD_REPEAT_RULE)
|
|
||
| ## Notes | ||
|
|
||
| For some reason, the `type_attribute` config method is not working the the `CellarIdSet` type, therefore whenever `prost_build` gets run, we have to manually add the `serde::Deserialize` and `serde::Serialize` attributes to it. |
There was a problem hiding this comment.
Fix the typo.
There is a repeated word "the" in the sentence.
- is not working the the `CellarIdSet` type
+ is not working with the `CellarIdSet` typeCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| For some reason, the `type_attribute` config method is not working the the `CellarIdSet` type, therefore whenever `prost_build` gets run, we have to manually add the `serde::Deserialize` and `serde::Serialize` attributes to it. | |
| For some reason, the `type_attribute` config method is not working with the `CellarIdSet` type, therefore whenever `prost_build` gets run, we have to manually add the `serde::Deserialize` and `serde::Serialize` attributes to it. |
Tools
LanguageTool
[duplication] ~5-~5: Possible typo: you repeated a word
Context: ...attributeconfig method is not working the theCellarIdSet` type, therefore whenever ...(ENGLISH_WORD_REPEAT_RULE)
| // TODO(fdymylja): once we fully migrate to protov2 the go_package needs to be updated. | ||
| // We need this right now because gogoproto codegen needs to import the extension. |
There was a problem hiding this comment.
Offer assistance for the TODO comment.
The TODO comment indicates a pending migration to protov2.
Do you want me to help with the migration to protov2 or open a GitHub issue to track this task?
Summary by CodeRabbit
New Features
somm_burn_ratioto auction parameters to specify the burn ratio of SOMM received from bids.HttpBodymessage for handling non-JSON payloads.Improvements
Documentation