Axelar with main merged, fixes, upgrade updates #236
Conversation
* v5 upgrade with only incentives and gravity updates * go.mod major version v4 -> v5 * go 1.15 -> 1.16 * Update prost_build and somm_proto * Generate somm_proto for v5 * Fix proto import path bug and regenerate protos * Fix linter * Pin to ubuntu version in releaser * Set incentives cutoff height
put back dragonberry replace directive after sdk downgrade to match gravity
EricBolten
requested review from
jackzampolin,
kkennis and
mvid
as code owners
We're long since past v4 and it breaks on the new Cosmos SDK. Was only here for historical reasons.
| -----END CERTIFICATE----- | ||
| ` | ||
|
|
||
| const FrenchChocolatineSubscriberCA = `-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
Probably fine for this PR but I know at least this validator has dropped from the active set. Would it be worth culling inactive validators from this list? I can go through the list if you need me to.
There was a problem hiding this comment.
I double-checked all the validators in the upgrade against steward-registry and left in the inactive ones, just to have this mirror the current state we're working with. If you want to spend the time to verify which ones we should remove, go for it, although there isn't really a method for scrubbing dead subscribers post-upgrade unless they delete their subscriber themselves, I don't think. So there will likely be cruft no matter what.
| @@ -49,38 +49,73 @@ func auctionInitGenesis(ctx sdk.Context, auctionKeeper auctionkeeper.Keeper) { | |||
| genesisState := auctiontypes.DefaultGenesisState() | |||
|
|
|||
| usomm52WeekLow := sdk.MustNewDecFromStr("0.079151") | |||
| eth52WeekHigh := sdk.MustNewDecFromStr("2359.89") | |||
There was a problem hiding this comment.
I am wondering if we about multiply these prices by 1.5 given market conditions
There was a problem hiding this comment.
We could, 52 week high is an arbitrary choice. At the same time, since prices are denominated in SOMM and we are choosing SOMM's 52 week low, it should have the effect of overpricing in most market conditions. But perhaps adding a flat multiplier on top of it as a param or something would be a good move. We can also control when these prices time out with that auction parameter so they'll have to be updated every N blocks.
Cleanly merge main into Axelar, fix some bugs, update the v7 upgrade handler.