Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop mirror: introduce opt-in setting to skip destination dropping #2455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Jan 18, 2025

This PR introduces a flag for the input of drop mirror to not bother with trying to drop destination peer artifacts.

  • Useful in cases where the target data store no longer exists, or if the user wishes for the cdc raw table to remain or has some dependencies on it

Open to renaming or rewiring the flag

PeerName: input.FlowConnectionConfigs.DestinationName,
})
selector.AddFuture(dropDestinationFuture, dropDestination)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
} else {
destinationOk = true
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants