Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support tls_cert/tls_key in nexus #2355

Merged
merged 1 commit into from
Jan 8, 2025
Merged

support tls_cert/tls_key in nexus #2355

merged 1 commit into from
Jan 8, 2025

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Dec 13, 2024

Need to contribute upstream to pgwire:

  1. tokio-rustls should be reexported since we must use same version of TlsAcceptor as them
  2. feature should not add parameter to public facing api method, as adding features should never break code

@serprex
Copy link
Contributor Author

serprex commented Dec 13, 2024

sunng87/pgwire#228

@serprex serprex marked this pull request as ready for review December 19, 2024 22:21
@serprex serprex enabled auto-merge (squash) January 8, 2025 17:57
@serprex serprex merged commit f806e04 into main Jan 8, 2025
14 checks passed
@serprex serprex deleted the nexus-tls branch January 8, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamKunalGupta iamKunalGupta iamKunalGupta approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@heavycrystal heavycrystal Awaiting requested review from heavycrystal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serprex @iamKunalGupta