setup mysql source, skip when test relies on Connector

PeerDB-io · Jan 9, 2025 · ae4257a · ae4257a
1 parent 1c82250
commit ae4257a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/flow/e2e/clickhouse/clickhouse.go b/flow/e2e/clickhouse/clickhouse.go
@@ -35,7 +35,11 @@ func (s ClickHouseSuite) T() *testing.T {
 }
 
 func (s ClickHouseSuite) Connector() *connpostgres.PostgresConnector {
-	return s.source.Connector().(*connpostgres.PostgresConnector)
+	c, ok := s.source.Connector().(*connpostgres.PostgresConnector)
+	if !ok {
+		s.t.Skip(fmt.Sprintf("skipping test because it relies on PostgresConnector, while source is %T", s.source))
+	}
+	return c
 }
 
 func (s ClickHouseSuite) DestinationConnector() connectors.Connector {

diff --git a/flow/e2e/clickhouse/peer_flow_ch_test.go b/flow/e2e/clickhouse/peer_flow_ch_test.go
@@ -31,7 +31,7 @@ func TestPeerFlowE2ETestSuitePG_CH(t *testing.T) {
 }
 
 func TestPeerFlowE2ETestSuiteMySQL_CH(t *testing.T) {
-	// TODO e2eshared.RunSuite(t, SetupSuite(t, e2e.SetupMySQL))
+	e2eshared.RunSuite(t, SetupSuite(t, e2e.SetupMySQL))
 }
 
 func (s ClickHouseSuite) attachSchemaSuffix(tableName string) string {

diff --git a/flow/e2e/mysql.go b/flow/e2e/mysql.go
@@ -19,7 +19,7 @@ var mysqlConfig = &protos.MySqlConfig{
 	Port:        3306,
 	User:        "root",
 	Password:    "maria",
-	Database:    "default",
+	Database:    "",
 	Setup:       nil,
 	Compression: 0,
 	DisableTls:  true,
@@ -62,7 +62,7 @@ func (s *MySqlSource) Teardown(t *testing.T, suffix string) {
 func (s *MySqlSource) GeneratePeer(t *testing.T) *protos.Peer {
 	t.Helper()
 	peer := &protos.Peer{
-		Name: "catalog",
+		Name: "mysql",
 		Type: protos.DBType_MYSQL,
 		Config: &protos.Peer_MysqlConfig{
 			MysqlConfig: mysqlConfig,