MOB-875 Adding MobileMoney Charge endpoint #101
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Peter-John-paystack
commented
Nov 24, 2023
Peter-John-paystack
commented
- Added Mobile Money as a supported channel - Added endpoint for Mobile Money charge - Added listener for mobile money events - Added unit tests for endpoint and listener for mobile money charge - Added Mock responses - Updated tests to support mobile money as a channel
- Added Mobile Money as a supported channel - Added endpoint for Mobile Money charge - Added listener for mobile money events - Added unit tests for endpoint and listener for mobile money charge - Added Mock responses - Updated tests to support mobile money as a channel
- Added Mobile Money as a supported channel - Added endpoint for Mobile Money charge - Added listener for mobile money events - Added unit tests for endpoint and listener for mobile money charge - Added Mock responses - Updated tests to support mobile money as a channel
- Added Mobile Money as a supported channel - Added endpoint for Mobile Money charge - Added listener for mobile money events - Added unit tests for endpoint and listener for mobile money charge - Added Mock responses - Updated tests to support mobile money as a channel
| } | ||
|
|
||
| // MARK: - Display | ||
| public struct Display: Codable { |
There was a problem hiding this comment.
@Peter-John-paystack The name should probably have a "MobileMoney" prefix to tie it more to the channel since we don't know if there'll be another "Display" object in the near future.
There was a problem hiding this comment.
Or we could make it a child of the MobileMoneyChargeData struct.
There was a problem hiding this comment.
Yeah I can still make that change @michael-paystack Good catch.
- Added Mobile Money as a supported channel - Added endpoint for Mobile Money charge - Added listener for mobile money events - Added unit tests for endpoint and listener for mobile money charge - Added Mock responses - Updated tests to support mobile money as a channel
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sources/PaystackSDK/Core/Models/Models/VerifyAccessCode/ChannelOptions.swift
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.