metdata now properly deep copied

PaulSchweizer · Sep 28, 2018 · 9c2bf79 · 9c2bf79
1 parent f7d6a32
commit 9c2bf79
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/flowpipe/node.py b/flowpipe/node.py
@@ -10,6 +10,7 @@
     import importlib
 except ImportError:
     pass
+import copy
 import imp
 import inspect
 import json
@@ -288,10 +289,11 @@ def __init__(self, func=None, outputs=None, name=None,
 
     def __call__(self, **kwargs):
         """Create and return an instance of the Node."""
-        self.metadata.update(kwargs.pop("metadata", {}))
+        metadata = copy.deepcopy(self.metadata)
+        metadata.update(kwargs.pop("metadata", {}))
         return self.__class__(func=self.func,
                               outputs=[o for o in self.outputs],
-                              metadata=self.metadata,
+                              metadata=metadata,
                               **kwargs)
 
     def compute(self, *args, **kwargs):

diff --git a/tests/test_convert_function_to_node.py b/tests/test_convert_function_to_node.py
@@ -144,3 +144,13 @@ def function(arg_1, arg_2="test_1", arg_3="test_2"):
     assert node.inputs["arg_2"].value is "test_1"
     assert node.inputs["arg_3"].value is "test_2"
 
+
+def test_metadata_is_unique_for_each_node_created():
+    @Node(metadata={"key": [1, 2, 3]})
+    def function():
+        pass
+
+    node1 = function()
+    node2 = function()
+
+    assert node1.metadata is not node2.metadata