Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure tests #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mark-henry
Copy link

expected: I should be able to clone the repository and implement the practice test, with minimal work that does not imitate the work I have to do for the real GCF
actual: I had to get the tests set up, there was output like "uploaded at filename.txt" that my code was expected to return, expected output did not conform to the specification (for example, the spec says that "get" should return only the file size) and in general it was too dissimilar from the real GCF environment

I have rewritten the tests so that the test-taker can just get straight to work on their implementation! :)

I have also restructured them to be easier to read: each command is now directly paired with its expected output.

@ludomitch
Copy link

Even in these proposed changes, it's still not testing what the functions are supposed to do. Most asserts are if the function returns None. Not for example, if it has actually stored a file. Or asserting a runtime exception if the file already exists.

I imagine the repo is still in progress. @PaulLockett ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants