Implement Hard Update Behaviour #9
Conversation
|
I haven't checked everything but I believe you're making good work :) Can you please squash all your commits into one? Then I'll merge the PR! Thanks! |
In theory, the validation script I wrote proves that this works as intended. However, whether the validation script is (unintentionally) incorrect has not been tested. In general though, the logic of both the new methods and testing are sound to the best of my code reading. Will get around to squashing in the next few days, however, Configuring commit squashing for pull requests may be a way for you to do so in the meantime (and future). |
Squashed commit of the following: commit fd13394 Author: Pon Pon <[email protected]> Date: Sat Nov 2 22:55:46 2024 -0700 Improve error logging of validation script commit 3671c06 Author: Pon Pon <[email protected]> Date: Wed Oct 30 13:31:27 2024 -0700 Add validation notes to README commit 8a53b75 Author: Pon Pon <[email protected]> Date: Wed Oct 30 13:19:07 2024 -0700 Update README - Add environment variables section commit b945091 Author: Pon Pon <[email protected]> Date: Wed Oct 30 13:17:10 2024 -0700 Update README - Correct HARD_UPDATE to better explain its behavior - Add note on resuming progress commit ef5ddbe Author: Pon Pon <[email protected]> Date: Thu Oct 24 12:44:40 2024 -0700 Make script to check changes to dump Signed-off-by: Pon Pon <[email protected]> commit c270c57 Author: Pon Pon <[email protected]> Date: Sun Oct 20 16:41:55 2024 -0700 Remove skipping unreleased games Skipping unreleased games provided minimal speedup, and with a dedicated hard update function is no longer necessary (in fact, keeping them will speed up future "soft" updates). Furthermore, we need to keep all games that have been seen to be compatable with the new "resume previous dump" functionality. commit 886042c Author: Pon Pon <[email protected]> Date: Sun Oct 20 13:21:44 2024 -0700 Remove old FULL_DUMP documentation commit eba4090 Author: Pon Pon <[email protected]> Date: Sun Oct 20 13:14:07 2024 -0700 Cleanup and formatting commit 88f8433 Merge: 90b1b14 83d8813 Author: Pon Pon <[email protected]> Date: Sun Oct 20 13:02:17 2024 -0700 Merge commit '83d8813c31b6441323cb1acbbadabc012f9b0afa' (romatthe/SteamAppsList) into hardupdate (Tropingenie/SteamAppsList) commit 90b1b14 Author: Pon Pon <[email protected]> Date: Sun Oct 20 12:46:29 2024 -0700 Add lock file and check for failed/interrupted run commit 385212f Author: Pon Pon <[email protected]> Date: Sun Oct 20 10:53:10 2024 -0700 Implement saving every 10 batches (fix PaulCombal#5) commit 66c04c9 Author: Pon Pon <[email protected]> Date: Sat Oct 19 15:41:44 2024 -0700 Change HARD_UPDATE to only update bad entries, mitigates issue PaulCombal#1 commit ff2acac Author: Pon Pon <[email protected]> Date: Sat Oct 19 12:16:23 2024 -0700 Update README with HARD_UPDATE documentation commit 9209732 Author: Pon Pon <[email protected]> Date: Sat Oct 19 12:14:28 2024 -0700 Add HARD_UPDATE flag and functionality commit 83d8813 Author: Robin Mattheussen <[email protected]> Date: Thu Feb 29 01:20:33 2024 +0100 Formattign and cleanup commit e822b3f Author: Robin Mattheussen <[email protected]> Date: Thu Feb 29 00:54:00 2024 +0100 Skip unreleased games and reduce payload size for querying app details commit b3f8166 Author: Robin Mattheussen <[email protected]> Date: Thu Feb 29 00:37:51 2024 +0100 Added ability to take a complete dump from scratch
Tropingenie
force-pushed
the
hardupdate
branch
from
fd13394
to
eae9b90
Compare
|
Oh yes you're right, I just figured out I could have done it myself.. the blame is on me! Anyway LGTM! Thanks for the contribution! |
No worries, I just came across it while... totally not searching how to squash a commit (despite knowing git). Seemed relevant so figured I would link it for informational purposes :) |
As discussed in PaulCombal/SamRewritten#166 by @romatthe, this PR had the primary goal of implementing the ability to update previous null entries. This does so non-destructively, only removing previous entries of
type == "game"andachievements == null, rather than the previous POC that removed all old entries. This also merges @romatthe's changes that greatly speed up the dumps, and implements some QoL features that are relevant.