Merge branch 'dev'

CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## [v2.33.4](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v2.33.4) (2023/08/28)
+
+[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.33.3...v2.33.4)
+
+<!-- Release notes generated using configuration in .github/release.yml at dev -->
+
+## What's Changed
+### Fixed Crashes
+- Fix crash when using Kitava's Thirst [\#6531](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6531) ([Paliak](https://github.com/Paliak))
+- Fix crash when loading some 3.20 builds [\#6525](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6525) ([Peechey](https://github.com/Peechey))
+### Fixed Bugs
+- Temporarily Revert trigger rate calculations to old formula [\#6530](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6530) ([Paliak](https://github.com/Paliak))
+- Fix Doom Blast overlap count not affecting DPS [\#6541](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6541) ([Paliak](https://github.com/Paliak))
+- Fix Skill Effect Duration affecting Totem duration [\#6536](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6536) ([Paliak](https://github.com/Paliak))
+- Prevent Tawhoa's Chosen Attacks from being Exerted [\#6535](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6535) ([Paliak](https://github.com/Paliak))
+- Fix crash when adding Support gems to some skills [\#6510](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6510) ([Paliak](https://github.com/Paliak))
+- Fix Mirage Archer disabling skills supported by Manaforged Arrows [\#6521](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6521) ([Paliak](https://github.com/Paliak))
+
+
+
 ## [v2.33.3](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v2.33.3) (2023/08/26)
 
 [Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.33.2...v2.33.3)

changelog.txt

@@ -1,3 +1,18 @@
+VERSION[2.33.4][2023/08/28]
+
+--- Fixed Crashes ---
+* Fix crash when using Kitava's Thirst (Paliak)
+* Fix crash when loading some 3.20 builds (Peechey)
+
+--- Fixed Bugs ---
+* Temporarily Revert trigger rate calculations to old formula (Paliak)
+* Fix Doom Blast overlap count not affecting DPS (Paliak)
+* Fix Skill Effect Duration affecting Totem duration (Paliak)
+* Prevent Tawhoa's Chosen Attacks from being Exerted (Paliak)
+* Fix crash when adding Support gems to some skills (Paliak)
+* Fix Mirage Archer disabling skills supported by Manaforged Arrows (Paliak)
+
+
 VERSION[2.33.3][2023/08/26]
 
 --- Fixed Bugs ---

src/Classes/ConfigTab.lua

@@ -528,6 +528,9 @@ function ConfigTabClass:Load(xml, fileName)
 				if node.attrib.name == "enemyIsBoss" then
 					self.input[node.attrib.name] = node.attrib.string:lower():gsub("(%l)(%w*)", function(a,b) return s_upper(a)..b end)
 					:gsub("Uber Atziri", "Boss"):gsub("Shaper", "Pinnacle"):gsub("Sirus", "Pinnacle")
+				-- backwards compat <=3.20, Uber Atziri Flameblast -> Atziri Flameblast
+				elseif node.attrib.name == "presetBossSkills" then
+					self.input[node.attrib.name] = node.attrib.string:gsub("^Uber ", "")
 				else
 					self.input[node.attrib.name] = node.attrib.string
 				end

src/Classes/Item.lua

@@ -1024,8 +1024,10 @@ function ItemClass:BuildRaw()
 		t_insert(rawLines, "Selected Variant: " .. self.variant)
 
 		for _, baseLine in pairs(self.baseLines) do
-			writeModLine(baseLine)
-		end
+			if baseLine.variantList then
+				writeModLine(baseLine)
+			end
+		end	
 		if self.hasAltVariant then
 			t_insert(rawLines, "Has Alt Variant: true")
 			t_insert(rawLines, "Selected Alt Variant: " .. self.variantAlt)
@@ -1574,7 +1576,7 @@ function ItemClass:BuildModList()
 				noSupports = skill.noSupports,
 				source = self.modSource,
 				triggered = skill.triggered,
-				triggerChance = skill.triggerChance
+				triggerChance = skill.triggerChance,
 			})
 		end
 	end