fix: vendor gli port for cmake 4.0 compatibility #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 4.0 removed previously deprecated backwards compatibility for CMake versions less than 3.5. As the GitHub action runner for `windows-latest` now has CMake 4.0, our CI runs have started failing. To address this we vendor the `gli` port from upstream `vcpkg` with a patch to bump its minimum CMake requirement declared in the `gli` CMake scripts.
It doesn't suffice to just have a port in the registry, `vcpkg-configuration.json` also needs to pull it in from the baseline.
Wires77
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 4.0 removed previously deprecated backwards compatibility for CMake versions less than 3.5.
As the GitHub action runner for
windows-latestnow has CMake 4.0, our CI runs have started failing. To address this we vendor thegliport from upstreamvcpkgwith a patch to bump its minimum CMake requirement declared in thegliCMake scripts.