Skip to content

Support importing characters from PoE API #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 6, 2025
Merged

Support importing characters from PoE API #845

merged 28 commits into from
Apr 6, 2025

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Mar 28, 2025

Initially copied from: PathOfBuildingCommunity/PathOfBuilding#8525

This is a very early implementation of PoB interacting with PoE's OAuth API. I wanted to get this out there in draft for early reviews and to organize my thoughts while I check things off the list:

Required for MVP:

  • TODO statements
  • Hardening/Logging
  • Investigate if SO_EXCLUSIVEADDRUSE is set in luasocket (part of hardening)
    -- Pretty sure this only applies to pre-Windows 2003 installs and people running PoB in compatibility mode for that. I did submit a PR to luasocket before realizing that, but I may not need to bake it into PoB's implementation
  • Automatic token acquisition on 401 error
  • Add luasocket license
  • Open SimpleGraphic PR for luasocket artifacts
  • Server start and timeout messaging/UX

Future goals:

  • Secure token storage
  • Refresh token usage and storage
  • Investigate behavior and QoL with multiple PoB instances open (Access token currently stored in memory, focus PoB window when redirect is made, etc)

@Wires77 Wires77 marked this pull request as draft March 28, 2025 02:39
@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 4, 2025
@Wires77 Wires77 marked this pull request as ready for review April 4, 2025 19:55
@Wires77 Wires77 merged commit 4e32fb1 into dev Apr 6, 2025
1 of 2 checks passed
@LocalIdentity LocalIdentity deleted the oauth branch April 6, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants