Skip to content

Fix Gamblesprint missing movement speed mod #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

PGDeve
Copy link
Contributor

@PGDeve PGDeve commented Jan 22, 2025

Fixes #112 .

Description of the problem being solved:

Extra lightning removed (already included in current variant).
Unique movement speed mod now shows correctly after improving the regex to hide 0-value modifiers.

Steps taken to verify a working solution:

  • Tested on POB2
  • All tests successful
  • Checked on trade

Link to a build that showcases this PR:

https://pobb.in/EBYaDilf3RIp

Before screenshot:

before

After screenshot:

after

@LocalIdentity LocalIdentity changed the title Fix Gamplesprint missing movement speed mod Fix Gamblesprint missing movement speed mod Jan 22, 2025
@PGDeve PGDeve marked this pull request as draft January 22, 2025 15:58
@PGDeve PGDeve marked this pull request as ready for review January 22, 2025 16:03
@Wires77 Wires77 merged commit 1682906 into PathOfBuildingCommunity:dev Jan 23, 2025
1 of 2 checks passed
@Wires77 Wires77 added the bug: accuracy Wording differences label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gamplesprint missing movement speed mod
2 participants