Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivareh patch 1 #683

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Ivareh patch 1 #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84cb275
Fix loggers messages in poe_api_handler.py
Ivareh Nov 18, 2024
688f638
Fix logger messages in external_data_ret main.py
Ivareh Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ta_retrieval/data_retrieval_app/external_data_retrieval/data_retrieval/poe_api_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def _get_latest_change_id(self) -> str:
)
response.raise_for_status()
except Exception as e:
logger.error("The following error occurred while making request:", e)
logger.error(f"The following error occurred while making request: {e}")
raise e
response_json = response.json()
next_change_id = response_json["psapi"]
Expand Down
3 changes: 1 addition & 2 deletions src/backend_data_retrieval/data_retrieval_app/external_data_retrieval/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,7 @@ def retrieve_data(self):
crashed_future = list(done_futures)[0]
future_job = futures.pop(crashed_future)
logger.info(
f"The future '{future_job}' has crashed. Finding exception...",
f"{done_futures=}",
f"The future '{future_job}' has crashed. Finding exception..."
)
if future_job == "data_processing":
crashed_future_exception = crashed_future.exception()
Expand Down
Loading