Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

273 Added exit and exit message to prestart script backend retrieval #424

Conversation

Ivareh
Copy link
Member

@Ivareh Ivareh commented Aug 28, 2024

Successful deposit:


~/Proggeprosjekter/pathofmodifiersapp/src 273-when-the-modifier_data_deposit-runs-exception-retrieve-data-runs-anyway*
venv ❯ docker logs src-backend-data-retrieval-1
/data_retrieval/modifier_data_deposit/deposit_modifier_data.py:6: DeprecationWarning: 
Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
(to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
but was not found to be installed on your system.
If this would cause problems for you,
please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466
        
  import pandas as pd

> Data modifier deposit successful. Continuing...

/data_retrieval/external_data_retrieval/main.py:11: DeprecationWarning: 
Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
(to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
but was not found to be installed on your system.
If this would cause problems for you,
please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466
        
  import pandas as pd
Starting the program.
Initializing follow stream threads
Waiting for futures to crash.

Negative deposit:


~/Proggeprosjekter/pathofmodifiersapp/src 273-when-the-modifier_data_deposit-runs-exception-retrieve-data-runs-anyway* 7s
venv ❯ docker logs src-backend-data-retrieval-1           
/data_retrieval/modifier_data_deposit/deposit_modifier_data.py:6: DeprecationWarning: 
Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
(to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
but was not found to be installed on your system.
If this would cause problems for you,
please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466
        
  import pandas as pd
Traceback (most recent call last):
  File "/data_retrieval/modifier_data_deposit/deposit_modifier_data.py", line 239, in <module>
    main()
  File "/data_retrieval/modifier_data_deposit/deposit_modifier_data.py", line 234, in main
    data_depositer.deposit_data()
  File "/data_retrieval/modifier_data_deposit/deposit_modifier_data.py", line 228, in deposit_data
    df = self._process_data(df)
         ^^^^^^^^^^^^^^^^^^^^^^
  File "/data_retrieval/modifier_data_deposit/deposit_modifier_data.py", line 207, in _process_data
    df = self._remove_duplicates(df.copy(deep=True))
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data_retrieval/modifier_data_deposit/deposit_modifier_data.py", line 200, in _remove_duplicates
    self._update_duplicates(duplicate_df, current_modifiers_df)
  File "/data_retrieval/modifier_data_deposit/deposit_modifier_data.py", line 156, in _update_duplicates
    data, put_update = check_for_updated_numerical_rolls(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data_retrieval/modifier_data_deposit/modifier_processing_modules.py", line 263, in check_for_updated_numerical_rolls
    min_roll = data["minRoll"]
               ~~~~^^^^^^^^^^^
KeyError: 'minRoll'

> Data modifier deposit failed. Exiting...

@bogadisa bogadisa merged commit cf9c82f into main Sep 2, 2024
5 checks passed
@bogadisa bogadisa deleted the 273-when-the-modifier_data_deposit-runs-exception-retrieve-data-runs-anyway branch September 2, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the modifier_data_deposit runs exception retrieve data runs anyway
2 participants