Add plausibility check for realtime_free_capacity values #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webapp/services/import_service/generic/generic_import_service.py
Outdated
Show resolved
Hide resolved
the-infinity
reviewed
Jan 3, 2025
| @@ -273,6 +273,34 @@ def _save_realtime_parking_site_input(self, source: Source, realtime_parking_sit | |||
| original_uid=realtime_parking_site_input.uid, | |||
| ) | |||
|
|
|||
| parking_site_capacities = [ | |||
There was a problem hiding this comment.
Typing :)
Also: the essential information is just one value: ' capacity' or 'capacity_woman' or ... . So it could be just a list of string, and then:
fields: list[str] = ['capacity', 'capacity_woman']
for field in fields:
realtime_free_capacity = getattr(realtime_parking_site_input, f'realtime_free_{field}')
There was a problem hiding this comment.
now resolved, thanks for the hint!
| setattr(realtime_parking_site_input, realtime_free_capacity, parking_site_capacity) | ||
| self.logger.warn( | ||
| LogMessageType.FAILED_PARKING_SITE_HANDLING, | ||
| f'At {parking_site.original_uid} from {source.id}, {realtime_free_capacity_type} {realtime_free_capacity} was higher than {realtime_capacity_type} {parking_site_capacity}', |
There was a problem hiding this comment.
This line is to long. Please make sure that you use ruff before committing. This can be done automatically using the pre commit hook which is part of the project. For more information about pre commit hooks, please visit https://pre-commit.com (not sure if that works at Windows, though).
There was a problem hiding this comment.
I get this error, when I run pre commit hook:
Any idea on what the error is all about and how to resolve it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks if realtime free capacity
realtime_free_capacityvalues are higher than the actual capacity before saving. It sets the realtime capacity values to the value of the actual capacity if it is true. The same plausibilty check is applied to each capacity category e.g.realtime_free_capacity_woman,realtime_free_capacity_disabledetc.