Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some incorrect mappings #296

Draft
wants to merge 5 commits into
base: versions/1.21.x
Choose a base branch
from
Draft

fix some incorrect mappings #296

wants to merge 5 commits into from

Conversation

BasiqueEvangelist
Copy link

  • ServerPlayer#sendSystemMessage's bypassHiddenChat is renamed to overlay, since it also controls whether the message goes to the action bar
  • closeContainer and doCloseContainer's javadocs are changed to better reflect what they do
  • Container's invalid stillValid javadoc is removed and some other javadocs are changed to fit the methods more

@BasiqueEvangelist
fix docs of ServerPlayer's closeContainer and co
5e55125
@BasiqueEvangelist
rename bypassHiddenChat to overlay
324bc00 
This flag doesn't just bypass chat visibility, it also puts the message
in the action bar. overlay is what the field in
ClientboundSystemChatPacket is called, so that's what I use here.
@BasiqueEvangelist
fix bad Container mappings
fe47f15
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sciwhiz12 sciwhiz12 added bug An error, misspell, incorrect information, or other issue mappings Changes to the mapping data 1.21.x For Minecraft 1.21.x labels Aug 6, 2024
Matyrobbrt
Matyrobbrt requested changes Aug 7, 2024
View reviewed changes
data/net/minecraft/server/level/ServerPlayer.mapping Outdated Show resolved Hide resolved
data/net/minecraft/server/level/ServerPlayer.mapping
@@ -51,7 +51,7 @@ CLASS net/minecraft/server/level/ServerPlayer
ARG 3 dy
ARG 5 dz
METHOD closeContainer ()V
COMMENT Sets the current crafting inventory back to the 2x2 square.
COMMENT Closes the container the player currently has open.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as below

data/net/minecraft/world/Container.mapping Outdated Show resolved Hide resolved
Lanse505
Lanse505 approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@Lanse505 Lanse505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lanse505 Lanse505 Lanse505 approved these changes

@Matyrobbrt Matyrobbrt Awaiting requested review from Matyrobbrt

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
1.21.x For Minecraft 1.21.x bug An error, misspell, incorrect information, or other issue mappings Changes to the mapping data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BasiqueEvangelist @CLAassistant @Lanse505 @Matyrobbrt @sciwhiz12