Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor solution #56

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Sat.Recruitment.Api/Business/DTOs/UserDTO.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
namespace Sat.Recruitment.Api.Business.DTOs
{
public class UserDTO
{
public string Name { get; set; }
public string Email { get; set; }
public string Address { get; set; }
public string Phone { get; set; }
public string UserType { get; set; }
public decimal Money { get; set; }
}
}
12 changes: 12 additions & 0 deletions Sat.Recruitment.Api/Business/Entities/User.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
namespace Sat.Recruitment.Api.Business.Entities
{
public class User
{
public string Name { get; set; }
public string Email { get; set; }
public string Address { get; set; }
public string Phone { get; set; }
public UserType UserType { get; set; }
public decimal Money { get; set; }
}
}
9 changes: 9 additions & 0 deletions Sat.Recruitment.Api/Business/Entities/UserType.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
namespace Sat.Recruitment.Api.Business.Entities
{
public enum UserType
{
Normal,
SuperUser,
Premium
}
}
8 changes: 8 additions & 0 deletions Sat.Recruitment.Api/Business/Responses/Response.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
namespace Sat.Recruitment.Api.Business.Responses
{
public class Response
{
public bool IsSuccess { get; set; }
public string Message { get; set; }
}
}
12 changes: 12 additions & 0 deletions Sat.Recruitment.Api/Business/Services/IUserService.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
using Sat.Recruitment.Api.Business.Entities;
using System.Threading.Tasks;

namespace Sat.Recruitment.Api.Business.Services
{
public interface IUserService
{
//Task<User> Update(User user);
//Task<User> Delete(User user);
Task<bool> Create(User user);
}
}
44 changes: 44 additions & 0 deletions Sat.Recruitment.Api/Business/Services/UserService.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
using System;
using System.Threading.Tasks;
using Sat.Recruitment.Api.Data.Repositories;
using Sat.Recruitment.Api.Business.Entities;
using Sat.Recruitment.Api.Business.Strategies;
using Sat.Recruitment.Api.Business.Utils;

namespace Sat.Recruitment.Api.Business.Services
{
public class UserService : IUserService
{
private readonly IRepository<User> _userRepository;

public UserService(IRepository<User> userRepository)
{
_userRepository = userRepository;
}

public async Task<bool> Create(User user)
{
IGiftStrategy giftStrategy = GetGiftStrategy(user);

var userGiftContext = new GiftContext(giftStrategy);
userGiftContext.ApllyGift(user);

user.Email = Helper.NormalizeMail(user.Email);

var result = await _userRepository.Create(user);

return result;
}

private static IGiftStrategy GetGiftStrategy(User user)
{
return user.UserType switch
{
UserType.Normal => new NormalGiftStrategy(),
UserType.SuperUser => new SuperUserStrategy(),
UserType.Premium => new PremiumGiftStrategy(),
_ => throw new Exception("Error in userType")
};
}
}
}
10 changes: 10 additions & 0 deletions Sat.Recruitment.Api/Business/Strategies/BaseStrategy.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
namespace Sat.Recruitment.Api.Business.Strategies
{
public class BaseStrategy
{
public decimal CalculateGift(decimal money, decimal percentaje)
{
return money * percentaje;
}
}
}
19 changes: 19 additions & 0 deletions Sat.Recruitment.Api/Business/Strategies/GiftContext.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
using Sat.Recruitment.Api.Business.Entities;

namespace Sat.Recruitment.Api.Business.Strategies
{
public class GiftContext
{
private readonly IGiftStrategy _giftStrategy;

public GiftContext(IGiftStrategy giftStrategy)
{
_giftStrategy = giftStrategy;
}

public void ApllyGift(User user)
{
_giftStrategy.ApplyGift(user);
}
}
}
9 changes: 9 additions & 0 deletions Sat.Recruitment.Api/Business/Strategies/IGiftStrategy.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
using Sat.Recruitment.Api.Business.Entities;

namespace Sat.Recruitment.Api.Business.Strategies
{
public interface IGiftStrategy
{
void ApplyGift(User user);
}
}
19 changes: 19 additions & 0 deletions Sat.Recruitment.Api/Business/Strategies/NormalGiftStrategy.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
using Sat.Recruitment.Api.Business.Entities;

namespace Sat.Recruitment.Api.Business.Strategies
{
public class NormalGiftStrategy : BaseStrategy, IGiftStrategy
{
public void ApplyGift(User user)
{
if (user.Money > 100)
{
user.Money += CalculateGift(user.Money, 0.12m);
}
else if (user.Money > 10)
{
user.Money += CalculateGift(user.Money, 0.8m);
}
}
}
}
12 changes: 12 additions & 0 deletions Sat.Recruitment.Api/Business/Strategies/PremiumGiftStrategy.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
using Sat.Recruitment.Api.Business.Entities;

namespace Sat.Recruitment.Api.Business.Strategies
{
public class PremiumGiftStrategy : BaseStrategy, IGiftStrategy
{
public void ApplyGift(User user)
{
user.Money += CalculateGift(user.Money, 2);
}
}
}
15 changes: 15 additions & 0 deletions Sat.Recruitment.Api/Business/Strategies/SuperUserStrategy.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
using Sat.Recruitment.Api.Business.Entities;

namespace Sat.Recruitment.Api.Business.Strategies
{
public class SuperUserStrategy : BaseStrategy, IGiftStrategy
{
public void ApplyGift(User user)
{
if (user.Money > 100)
{
user.Money += CalculateGift(user.Money, 0.20m);
}
}
}
}
19 changes: 19 additions & 0 deletions Sat.Recruitment.Api/Business/Utils/Helper.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
using System;

namespace Sat.Recruitment.Api.Business.Utils
{
public class Helper
{
public static string NormalizeMail(string email)
{
//Normalize email
var aux = email.Split(new char[] { '@' }, StringSplitOptions.RemoveEmptyEntries);

var atIndex = aux[0].IndexOf("+", StringComparison.Ordinal);

aux[0] = atIndex < 0 ? aux[0].Replace(".", "") : aux[0].Replace(".", "").Remove(atIndex);

return string.Join("@", new string[] { aux[0], aux[1] });
}
}
}
22 changes: 22 additions & 0 deletions Sat.Recruitment.Api/Business/Validations/UserValidator.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
using FluentValidation;
using FluentValidation.Validators;
using Sat.Recruitment.Api.Business.DTOs;
using Sat.Recruitment.Api.Business.Entities;
using System;

namespace Sat.Recruitment.Api.Business.Validations
{
public class UserValidator : AbstractValidator<UserDTO>
{
private const string ERROR_MESSAGE = "The {PropertyName} is required";

public UserValidator()
{
RuleFor(user => user.Name).Cascade(CascadeMode.Stop).NotEmpty().WithMessage(ERROR_MESSAGE).Length(2, 50);
RuleFor(user => user.Email).Cascade(CascadeMode.Stop).NotEmpty().WithMessage(ERROR_MESSAGE).EmailAddress(EmailValidationMode.AspNetCoreCompatible);
RuleFor(user => user.Address).Cascade(CascadeMode.Stop).NotEmpty().WithMessage(ERROR_MESSAGE);
RuleFor(user => user.Phone).Cascade(CascadeMode.Stop).NotEmpty().WithMessage(ERROR_MESSAGE).Matches(@"^[\\+]?[(]?[0-9]{3}[)]?[-\\s\\.]?[0-9]{3}[-\\s\\.]?[0-9]{4,6}$");
RuleFor(user => user.UserType).Cascade(CascadeMode.Stop).Must(x => Enum.TryParse(x, out UserType result)).WithMessage("The {PropertyName} is invalid");
}
}
}
Loading