Fix issue with import catalog (#217)

- Fixed an issue where the name of the catalog would be wrong when importing vms
Parallels · Oct 21, 2024 · ffb968d · ffb968d
1 parent 610ab1d
commit ffb968d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/catalog/import_vm.go b/src/catalog/import_vm.go
@@ -2,7 +2,6 @@ package catalog
 
 import (
 	"encoding/json"
-	"fmt"
 	"path/filepath"
 	"strings"
 
@@ -96,7 +95,7 @@ func (s *CatalogManifestService) ImportVm(ctx basecontext.ApiContext, r *models.
 				}
 				catalogManifest = models.NewVirtualMachineCatalogManifest()
 
-				catalogManifest.Name = fmt.Sprintf("%v-%v", r.CatalogId, r.Version)
+				catalogManifest.Name = r.Name()
 				catalogManifest.Type = r.Type
 				catalogManifest.Description = r.Description
 				catalogManifest.RequiredClaims = r.RequiredClaims
@@ -117,11 +116,10 @@ func (s *CatalogManifestService) ImportVm(ctx basecontext.ApiContext, r *models.
 					response.AddError(err)
 					break
 				}
-
 			}
 		} else {
 			catalogManifest = models.NewVirtualMachineCatalogManifest()
-			catalogManifest.Name = fmt.Sprintf("%v-%v", r.CatalogId, r.Version)
+			catalogManifest.Name = r.Name()
 			catalogManifest.Type = r.Type
 			catalogManifest.Description = r.Description
 			catalogManifest.RequiredClaims = r.RequiredClaims

diff --git a/src/data/main.go b/src/data/main.go
@@ -337,7 +337,6 @@ func (j *JsonDatabase) processSave(ctx basecontext.ApiContext) error {
 	if err = j.copyCurrentDbFileToTemp(ctx, dateTimeForFile); err != nil {
 		ctx.LogDebugf("[Database] Error copying current file to backup: %v", err)
 		j.isSaving = false
-		j.saveMutex.Unlock()
 		return err
 	}