Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new spellblade enchantment: Temporal. Also adds lightning knockdown back. #27314

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Qwertytoforty
Copy link
Contributor

What Does This PR Do

The lightning spellblade will knock down for 4 seconds on wizard spellblades when zapping someone, and 2 on miner. This is not a stun like when it was originally added.
The forcewall spellblade wizard version, can buff itself every 2 seconds instead of 4, to make uptime easier for wizards, without being too easy for the miner version.

Adds a new spellblade enchantment.
This spellblade halfs the base spellblade damage (from 25 to 12.5), but doubles it's attack speed. Each slash applies a stacking debuff, which lasts 3 seconds till the slashes stop.
Once they have not been stabbed for 3 seconds, the target takes a 20 damage (10 damage for miner) temporal slash every 0.25 seconds for each slash dealt to them (hit someone 5 times, they get slashed 5 times).
The temporal slashes also will do extra damage to megafauna, to make it a little bit more useful for miners, though note that it doesn't provide any damage resistance unlike a crusher, and you have to kill bubblegum for it.

Why It's Good For The Game

Lightning needs the umf back it lost, without being a stun.
Better uptime for forcewall is good.
A cool spellblade enchantment that is the best for direct damage, without being flashy in ways that lead to security frustration (Bluespace knockdown from range, forcewalls making batons and disablers useless), will provide a more flashy wizard option, if they want to be a bit silly with cool dramatic slashes, and fill out the pool for miners, giving them a spellblade that might actually work well on lavaland, without being something sec will want to suffer again.

Images of changes

https://imgur.com/a/XuHdiwI

Testing

See above, but also testing its damage vs miners.
Testing to make sure it slashes random limbs vs just chest.
Testing forcewalls uptime refresh.
Testing lightning knockdown.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image

Changelog

🆑
add: Adds a new spellblade enchantment: Temporal. Attacks twice as fast for half the damage, but each slash will curse the victim to be slashed again for 20 damage (or 10 for miner) for each time they have been cut,
tweak: Lightning spellblade now knocks down again. Miner spellblade knocks down for 2 seconds instead of 4
tweak: Wizard forcewall (not miner) spellblade can be refreshed every 2 seconds instead of 4.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Nov 7, 2024
@TravisAngeI
Copy link

TravisAngeI commented Nov 7, 2024

security eating 200 brute damage after thinking 'oh man that spellblade hurt its a good thing i got away just in time'

also really cool, look forward to seeing this

@SteelSlayer SteelSlayer added the Feature This PR is a new addition to the game label Nov 9, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 9, 2024
@SynthTwo
Copy link
Contributor

SynthTwo commented Nov 9, 2024

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Nov 9, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants