Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE/TGUI] TGUI agent ID #26937

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

Adrer
Copy link
Contributor

@Adrer Adrer commented Sep 29, 2024

What Does This PR Do

Re-opens [TGUI] Agent ID Card
Takes inspiration from Refactor Agent ID from SS220

Modernizes the agent ID by giving it a snazzy new interface, making it a lot easier to change your data on the fly without having to fumble with endless lists you need to open.

Features:

  • Copying names: You can now copy the name of any crew on the station with a single button.
  • Enable/disable tracking: It's now possible to turn tracking on/off on the agent ID, wheras it previously was always on.
  • Custom job HUD: It's now possible to select your security HUD icon seperately from your job title.
  • Generate random data: Easily generate random data for fields by right clicking the auto-fill button.

Why It's Good For The Game

A better UI, a better life.

Images of changes

2024-09-29.15-08-55.mp4

Testing

Try and change all of the things.
Copy the name of another person.
Cryo a person, their name can no longer be copied.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑 larentoun, Aylong
add: Agent ID now has a custom TGUI interface
tweak: You can now copy the name of anyone on manifest with the agent ID
tweak: You can turn AI tracking on and off with the agent ID
/:cl:

@ROdenFL
Copy link
Contributor

ROdenFL commented Sep 29, 2024

Are dropdowns still working bad? Choice in tgui input looks quite strange, since it isn't syndicate theme

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Sep 29, 2024
@BiancaWilkson BiancaWilkson added Feature This PR is a new addition to the game Tweak This PR tweaks something ingame labels Sep 29, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Sep 30, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Oct 10, 2024
Copy link
Contributor

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale This PR has been left inactive and requires an update. label Oct 31, 2024
@Adrer Adrer removed the Stale This PR has been left inactive and requires an update. label Nov 1, 2024
code/game/objects/items.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Nov 6, 2024
Copy link
Contributor

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks good to me. Please update bundle when able.

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Nov 11, 2024
code/game/objects/items/weapons/agent_id.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/agent_id.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/agent_id.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/agent_id.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/agent_id.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Feature This PR is a new addition to the game TGUI This PR modifies TGUI, will conflict Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants