-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SEO for home, dashboard, and event pages #91
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few fixes and we'll pick up from there
Added several features like twitter card, themecolor, viewport, and canonical Formated og::image better through revising its path and name
Have revised all the issues you have mentioned. You can review them and point out any further improvement that occurs on your mind. |
Have made the change |
@@ -36,7 +36,7 @@ const Home: NextPage = () => { | |||
return ( | |||
<> | |||
<Head> | |||
<link rel="icon" href="/favicon.ico" /> | |||
<link rel="icon" href="/public/fav_icon.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need /public
here as per above 🍡
I used next-seo to implement seo and revise browser titles for all major pages.
Please take a look at whether the format I added the para-og1 is correct for og, also whether I still need to include next-head for twitter og.