Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SEO for home, dashboard, and event pages #91

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

runzhao3
Copy link
Collaborator

I used next-seo to implement seo and revise browser titles for all major pages.

Please take a look at whether the format I added the para-og1 is correct for og, also whether I still need to include next-head for twitter og.

@runzhao3 runzhao3 requested review from RaymondWHZ and louisunlimited and removed request for RaymondWHZ August 29, 2023 15:43
Copy link
Member

@louisunlimited louisunlimited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few fixes and we'll pick up from there

src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
public/para_og1.png Outdated Show resolved Hide resolved
src/pages/index.tsx Show resolved Hide resolved
Added several features like twitter card, themecolor, viewport, and canonical
Formated og::image better through revising its path and name
@runzhao3
Copy link
Collaborator Author

Have revised all the issues you have mentioned. You can review them and point out any further improvement that occurs on your mind.

src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Show resolved Hide resolved
@runzhao3
Copy link
Collaborator Author

Have made the change

src/pages/index.tsx Outdated Show resolved Hide resolved
@@ -36,7 +36,7 @@ const Home: NextPage = () => {
return (
<>
<Head>
<link rel="icon" href="/favicon.ico" />
<link rel="icon" href="/public/fav_icon.png" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need /public here as per above 🍡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants