Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the KWordQuiz Icons #3577

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Conversation

monstorix
Copy link
Contributor

@monstorix monstorix commented Oct 27, 2023

KDE's word flash card program KWordQuiz got a new icon and redesigned interface after version 23.08.

Tried to redid the icons, since the old one got a plain design (looks like a txt file).
It's the first time for me to draw for the project, any feedback or the suggestion for improving the design are appreciated.

Old Papirus Icon
old
Recent Breeze Icon(Original Link)
breeze icon
Redesigned Icon
kwordquiz@64x64
screenshot

@morganist
Copy link
Contributor

I propose to un-tilt the icon, so it looks nice and pixel-perfect when rendered, without jagged edges. This is what i did with KWallet icon (#3538)

@monstorix
Copy link
Contributor Author

I propose to un-tilt the icon, so it looks nice and pixel-perfect when rendered, without jagged edges. This is what i did with KWallet icon (#3538)

Good advice. I'll make a try.

@morganist
Copy link
Contributor

Also, (assuming you're following the contributing guide) see the TEMPLATE.SVG files in /tools/work/Papirus/apps/ for an example of how shadows and outlines are done in Papirus. They are applied to the bounds of the main shape.

@SmartFinn
Copy link
Member

SmartFinn commented Oct 28, 2023

@raymond-nee the objects on these icons still have poor Pixel alignment. The question mark uses too many nodes:

image

You can reuse the question mark from apps/help-browser.svg icon instead.

Also, the shadows and light outline aren't matched Papirus style. See templates for example as @morganist recommended.

Please let me know if you have no time to fix it.

@monstorix
Copy link
Contributor Author

monstorix commented Oct 28, 2023

@raymond-nee the objects on these icons still have poor Pixel alignment. The question mark uses too many nodes:

@SmartFinn @morganist I've adjusted the question mark and shade, please let me know if the design still has other inflaws.

@SmartFinn
Copy link
Member

@raymond-nee seems you have used one question mark symbol for all sizes, when you should use the symbol from 16px icon for 16px, 22px for 22px, and next.

The pixel alignment is still poor, that make it icon is blurred. Please use pixel grid (Shift-3 in Inkscape) and see Pixel alignment how it should be.

@monstorix
Copy link
Contributor Author

The pixel alignment is still poor, that make it icon is blurred. Please use pixel grid (Shift-3 in Inkscape) and see Pixel alignment how it should be.

@SmartFinn I just finished the alignment work, please check if it is going right.

@SmartFinn
Copy link
Member

@raymond-nee not perfect, but much better. Thanks.

@SmartFinn SmartFinn merged commit d3b2450 into PapirusDevelopmentTeam:master Oct 28, 2023
1 check passed
SmartFinn added a commit that referenced this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants