Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python apps - add symlinks for versions >3.8 (from 3.8 to 3.11) #3559

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

gitadum
Copy link
Contributor

@gitadum gitadum commented Sep 19, 2023

Same goal as for PR #3058
But from a non-stale branch of the fork repo : )
Allows references to minor versions of python3 from 3.0 to 3.11 (lattest stable release in sept 2023)
So far it was only possible from 3.0 to 3.4

@gitadum gitadum changed the title add symlinks for python (from v3.5 to v3.11) Python apps - add symlinks for versions >3.4 (from 3.5 to 3.11) [Non-stale] Sep 19, 2023
@gitadum gitadum changed the title Python apps - add symlinks for versions >3.4 (from 3.5 to 3.11) [Non-stale] Python apps - add symlinks for versions >3.4 (from 3.5 to 3.11) [Update] Sep 19, 2023
@SmartFinn
Copy link
Member

Thanks. Could you add a link to a package that uses the icon names? I had look inside on Arch (incl. AUR), Debian, Ubuntu, Fedora packages, and didn't find a package with any of these icon names. They usually use idle3, python3 icons, or not providing a desktop-file and an icon at all.

@gitadum
Copy link
Contributor Author

gitadum commented Sep 20, 2023

You are right, in Ubuntu after installing python (eg 3.8) the default desktop app launcher defines Icon like this:
Icon=/usr/share/pixmaps/python3.8.xpm
While they don't use the theme icon, they keep being version specific when refering to an icon.
I had it changed for Icon=python3 but because I intended it. So far, no impact for python users except they change reference to the icon. Just thought it would be nice to let users with possibility to keep being version specific.

@SmartFinn
Copy link
Member

Hmm, as to me, I have to remove the symlinks for python2.6 - python3.4 too. At first, no one package doesn't use it. Even harcode-fixer that should unhardcode the icon, it changes the icon names to python, not to pythonN.N. Secondly, they're already outdated.

@SmartFinn
Copy link
Member

I change my mind. I'll merge the symlinks, but for supported versions only.

@gitadum could you remove the following symlinks:

  • python3.4
  • python3.5
  • python3.6
  • python3.7

@SmartFinn SmartFinn changed the title Python apps - add symlinks for versions >3.4 (from 3.5 to 3.11) [Update] Python apps - add symlinks for versions >3.8 (from 3.8 to 3.11) #3559 Oct 2, 2023
@SmartFinn SmartFinn merged commit 731f6b4 into PapirusDevelopmentTeam:master Oct 2, 2023
1 check passed
@SmartFinn SmartFinn changed the title Python apps - add symlinks for versions >3.8 (from 3.8 to 3.11) #3559 Python apps - add symlinks for versions >3.8 (from 3.8 to 3.11) Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants