Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set event result, and add warnings to velocity plugin messaging docs #479

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

456dev
Copy link
Contributor

@456dev 456dev commented Sep 3, 2024

as well as the warnings and updated example code, it also includes

  • more specific diagrams for each case
  • fixed identifier checking, rather than by identity
  • instanceof style cast.

also includes more specific diagrams for each case, fixed identifier checking, rather than by identity, and instanceof Player player style cast.
Copy link

github-actions bot commented Sep 3, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview f21de89

Copy link
Member

@zlataovce zlataovce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need someone familiar with Velocity to check whether the logic is correct, not familiar enough with it myself

docs/velocity/dev/api/plugin-messaging.mdx Outdated Show resolved Hide resolved
docs/velocity/dev/api/plugin-messaging.mdx Outdated Show resolved Hide resolved
docs/velocity/dev/api/plugin-messaging.mdx Outdated Show resolved Hide resolved
docs/velocity/dev/api/plugin-messaging.mdx Outdated Show resolved Hide resolved
docs/velocity/dev/api/plugin-messaging.mdx Outdated Show resolved Hide resolved
docs/velocity/dev/api/plugin-messaging.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants