Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework navigating configuration pages. #236

Merged

Conversation

olijeffers0n
Copy link
Member

Opening this as a PR to allow discussion, review and so i don’t forget it lol. Same as I showed in discord earlier.

@MiniDigger
Copy link
Member

I think I would remove the border around the files, make them proper links, and remove the color from the folder, since they are not links
I also would want to expand this to include all files paper creates. not every file (like the whitelist or the usercache or whatever) need a whole page, maybe those could have a popup when you click on them with a short text? that popup could be reused for the config files that arent documented yet.

@olijeffers0n
Copy link
Member Author

Worked on it a bit however I still can't work out how to align them on the z axis

# Conflicts:
#	docs/paper/admin/reference/configuration/README.mdx
@olijeffers0n olijeffers0n marked this pull request as ready for review February 22, 2024 00:32
Copy link
Contributor

@SandwichBtw SandwichBtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue if this is needed but it makes it clear what means.

src/components/ConfigurationStructureDiagram.tsx Outdated Show resolved Hide resolved
@powercasgamer
Copy link
Sponsor Contributor

Should version_history.json also be on here?

@olijeffers0n olijeffers0n merged commit 703e749 into PaperMC:main Mar 15, 2024
2 checks passed
@olijeffers0n olijeffers0n deleted the feat/new_configuration_page_layout branch March 15, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants