Mention missing World#regenerateChunk implementation in jd #12109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe change the message in the implementation too (and cleanup that comment code)? currently its like "if can fix..." |
|
It was re-implemented for a while in 1.18.1 in this commit, don't remember in what version it was removed again though |
|
Pretty recently iirc? We can deprecate for removal, the comment seems overkill. |
Yeah, seems like around 1.21/1.21.1, as 1.20.6 still had the api implemented |
notTamion
requested changes
Feb 14, 2025
lynxplay
approved these changes
Feb 15, 2025
notTamion
approved these changes
Feb 15, 2025
notTamion
approved these changes
Feb 15, 2025
Machine-Maker
approved these changes
Feb 15, 2025
Warriorrrr
approved these changes
Feb 15, 2025
Y2Kwastaken
pushed a commit
to Y2Kwastaken/Paper
that referenced
this pull request
Feb 16, 2025
…aperMC#12109) * Mention missing impl * Clean the implementation out of years old code * Change the jd comment * Move to default method --------- Co-authored-by: Bjarne Koll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.14 spigot removed the implementation of this api, but this information is still not present in the javadocs. This also deprecates for removal the api, as with newer versions it's harder and harder to imagine this api coming back.