Add proper attached blocks API to AbstractArrow #12099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
The only real concern I see would be getAttachedBlock not returning the block plugins are expecting in relation to the hit event. I would ponder deprecating the old method just for the "you should probably consider them all, or default to the first if that fits your needs"
Owen1212055
approved these changes
Feb 11, 2025
The Block that was hit in the hitevent is already Stored in a Variable (i think). could return that in the old method if it is still there |
lynxplay
reviewed
Feb 12, 2025
lynxplay
approved these changes
Feb 12, 2025
paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftAbstractArrow.java
Outdated
Show resolved
Hide resolved
notTamion
force-pushed
the
proper-attachedblocks-api
branch
from
d36aa47 to
ae017cd
Compare
Y2Kwastaken
pushed a commit
to Y2Kwastaken/Paper
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractArrows don't just have one block they are attached to. i definitely think we should expose all the blocks to the api. whether or not the existing method should be deprecated is up for debate though the current jd for it is misleading as it makes the user think there might only be one block keeping the arrow from falling
fixes #12096