Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sittable interface extend Entity #12016

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make Sittable interface extend Entity #12016

wants to merge 5 commits into from

Conversation

NonSwag
Copy link
Contributor

@NonSwag NonSwag commented Jan 26, 2025

closes #12014

@NonSwag NonSwag requested a review from a team as a code owner January 26, 2025 09:17
@lynxplay lynxplay added type: feature Request for a new Feature. scope: api labels Jan 26, 2025
@Machine-Maker
Copy link
Member

Machine-Maker commented Jan 26, 2025 •
edited
Loading

I'm not sure this is smart. What happens when a non-animal sittable mob is added? Not really out of the realm of possibility, in fact its probably likely. I would rather Sittable be made to extend Entity or LivingEntity since that's pretty much guaranteed to always be the case.

@Owen1212055 thoughts?

@Owen1212055
Copy link
Member

Agree, this should not be on Animals but Entity.

@NonSwag
Copy link
Contributor Author

NonSwag commented Jan 26, 2025

In that case I'd change the JD as well
They state an animal that may sit

@Machine-Maker
Copy link
Member

Yeah, that's fine. I don't really take a casual mention of "animal" to be an API contract that this type also implements Animals (btw, why is it plural? strange bukkit choices).

@Owen1212055
Copy link
Member

It’s been animals for ages, just an ancient relic.

@Lulu13022002 Lulu13022002 changed the title Make Sittable interface extend Animals Make Sittable interface extend Entity Jan 27, 2025
@NonSwag
Copy link
Contributor Author

NonSwag commented Jan 27, 2025

#12014 (comment)

@Lulu13022002
Copy link
Contributor

I think the overrides in Panda can be removed too, the javadoc is not more relevant than the parent one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytv kennytv kennytv approved these changes

@Machine-Maker Machine-Maker Machine-Maker approved these changes

Assignees
No one assigned
Labels
scope: api type: feature Request for a new Feature.
Projects
Paper PR Queue
Status: Awaiting final testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sittable does not extend any entity class
6 participants
@NonSwag @Machine-Maker @Owen1212055 @Lulu13022002 @kennytv @lynxplay