Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong piston world border check #12007

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Fix wrong piston world border check #12007

merged 2 commits into from
Jan 25, 2025

Conversation

HaHaWTH
Copy link
Contributor

@HaHaWTH HaHaWTH commented Jan 25, 2025

Closes #11983.

This pull request fixes vanilla wrong piston world border check(MC-82010, thanks to FX-PR0CESS)

Before(Paper 1.21.4 build 121):

before

After:

after

@HaHaWTH HaHaWTH requested a review from a team as a code owner January 25, 2025 18:33
@Warriorrrr Warriorrrr added the type: bug Something doesn't work as it was intended to. label Jan 25, 2025
@lynxplay
Copy link
Contributor

Given this isn't a full fix for the linked mojira issue, I'll update the comment.
We should also keep the old check as well as otherwise pistons outside the world border now start pushing things into, being stuck with the same problem.

@lynxplay
Copy link
Contributor

LGTM, thanks!
For any readers of this PR down the line, this is not a fix for the linked MC issue but a band aid fix specifically for the piston attempting to push blocks out of the world border 👍

@lynxplay lynxplay merged commit 81bb82f into PaperMC:main Jan 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynxplay lynxplay lynxplay approved these changes

@Machine-Maker Machine-Maker Machine-Maker approved these changes

Assignees
No one assigned
Labels
type: bug Something doesn't work as it was intended to.
Projects
Paper PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pushing a block outside the world border creates a glitchy moving block
4 participants
@HaHaWTH @lynxplay @Machine-Maker @Warriorrrr