Add API for client-side signs #11903
Conversation
paper-api/src/main/java/io/papermc/paper/event/packet/UncheckedSignChangeEvent.java
Show resolved
Hide resolved
...-server/patches/sources/net/minecraft/server/network/ServerGamePacketListenerImpl.java.patch
Outdated
Show resolved
Hide resolved
...-server/patches/sources/net/minecraft/server/network/ServerGamePacketListenerImpl.java.patch
Show resolved
Hide resolved
paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
Outdated
Show resolved
Hide resolved
paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
Outdated
Show resolved
Hide resolved
paper-api/src/main/java/io/papermc/paper/event/packet/UncheckedSignChangeEvent.java
Outdated
Show resolved
Hide resolved
lynxplay
force-pushed
the
client-side-sign-hf
branch
from
fd457fc to
3e064ce
Compare
| * Called when a client attempts to modify a sign, but the location at which the sign should be edited | ||
| * has not yet been checked for the existence of a real sign. | ||
| * <p> | ||
| * Cancelling this event will prevent further processing of the sign change, but needs further handling |
There was a problem hiding this comment.
In regards to this, is there a point in us just resending the block?
Usage of this event would always be with "ephemeral" signs.
Leaving this up to plugin developers feels pretty meh.
There was a problem hiding this comment.
I also pondered about doing it that way, but at the end I thought the event should just report back that the player tried to edit a sign and minimize other side effects.
There was a problem hiding this comment.
I mean, it's unchecked, and so I generally expect it to be a lot more 'dumb' in terms of how it interacts. I feel that such low level events are always going to be kinda meh
There was a problem hiding this comment.
Well I would not mind it if this event was low level on purely client side signs.
But the fact that this is also called for actual in-world signs makes this pretty annoying/easy to fuck up potentially leaving normal signs out of sync.
Could potentially have some cancel overload that allows passing some RESEND flag?
Allows using the editing of signs that are not placed on the server as text-input without meddling with packets.
Original: #9786