Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EntityEffectTickEvent #11838

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

LemonCaramel
Copy link
Contributor

Adds the EntityPotionTickEvent.

This event is triggered on each tick of the potion effect (e.g. every 25 ticks for Poison level 1), and if the event is cancelled, the potion effect will not be applied to the entity.

I have been using it in my personal fork for the past year, mainly to add additional effects on each tick of a potion effect.

@LemonCaramel LemonCaramel requested a review from a team as a code owner December 27, 2024 14:40
@NoahvdAa NoahvdAa added the type: feature Request for a new Feature. label Dec 30, 2024
@kennytv
Copy link
Member

kennytv commented Jan 11, 2025

Should be named EntityEffectTick or EntityPotionEffectTick. I think I'd prefer the first since it's technically not always associated with potions or potion specific effects

@LemonCaramel LemonCaramel force-pushed the feat/potion-tick-event branch from ae4d7f2 to c39ec54 Compare January 11, 2025 15:20
@LemonCaramel LemonCaramel changed the title Add EntityPotionTickEvent Add EntityEffectTickEvent Jan 11, 2025
@kennytv kennytv force-pushed the feat/potion-tick-event branch from c39ec54 to 1700d8a Compare January 12, 2025 16:41
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennytv kennytv merged commit 76617dd into PaperMC:main Jan 12, 2025
3 checks passed
@LemonCaramel LemonCaramel deleted the feat/potion-tick-event branch January 12, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Request for a new Feature.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants