fix: prevent karpenter from provisioning metal nodes

Panfactum · Oct 19, 2024 · 197fa7d · 197fa7d
1 parent 6921321
commit 197fa7d
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 3 deletions.
diff --git a/packages/infrastructure/kube_karpenter_node_pools/main.tf b/packages/infrastructure/kube_karpenter_node_pools/main.tf
@@ -41,15 +41,13 @@ locals {
     "m8g",
     "m7g",
     "m7i",
-    "m7i-flex",
     "m7a",
     "m6g",
     "m6i",
     "m6a",
     "c8g",
     "c7g",
     "c7i",
-    "c7i-flex",
     "c7a",
     "c6g",
     "c6gn",
@@ -68,12 +66,26 @@ locals {
     "x2iedn"
   ]
 
+  // Blacklisted sizes
+  // These sizes are not allowed as bare metals instances are incompatible
+  // with our base AMI
+  blacklisted_sizes = [
+    "metal",
+    "metal-24xl",
+    "metal-48xl"
+  ]
+
   shared_requirements = [
     {
       key      = "karpenter.k8s.aws/instance-family"
       operator = "In"
       values   = local.base_instance_families
     },
+    {
+      key      = "karpenter.k8s.aws/instance-size"
+      operator = "NotIn"
+      values   = local.blacklisted_sizes
+    },
     {
       key      = "kubernetes.io/os"
       operator = "In"
@@ -95,10 +107,17 @@ locals {
         [
           "t4g",
           "t3",
-          "t3a"
+          "t3a",
+          "c7i-flex",
+          "m7i-flex"
         ]
       )
     },
+    {
+      key      = "karpenter.k8s.aws/instance-size"
+      operator = "NotIn"
+      values   = local.blacklisted_sizes
+    },
     {
       key      = "kubernetes.io/os"
       operator = "In"

diff --git a/packages/website/src/app/changelog/edge/page.mdx b/packages/website/src/app/changelog/edge/page.mdx
@@ -9,6 +9,12 @@ Learn more [here](/docs/edge/guides/versioning/releases).*
 
 {/* lint disable no-duplicate-headings */}
 
+## Unreleased
+
+### Fixed
+
+* Prevents Karpenter from scheduling instances on bare metal instances which we have observed issues with.
+
 ## edge.24-10-18
 
 ### Breaking Changes

diff --git a/...eference/infrastructure-modules/submodule/workflow/wf_dockerfile_build/page.mdx b/...eference/infrastructure-modules/submodule/workflow/wf_dockerfile_build/page.mdx
@@ -171,6 +171,14 @@ Type: `string`
 
 Default: `""`
 
+### image\_tag\_prefix
+
+Description: The prefix to prepend to the image tag
+
+Type: `string`
+
+Default: `""`
+
 ### pull\_through\_cache\_enabled
 
 Description: Whether to use the ECR pull through cache for the deployed images