Added a test for AssetPathExtractor service

- Ensured build/index.html exists in constructor
Paneon · Jan 17, 2024 · 4a8d24f · 4a8d24f
1 parent d0de968
commit 4a8d24f
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 10 deletions.
diff --git a/src/Service/AssetPathExtractor.php b/src/Service/AssetPathExtractor.php
@@ -11,14 +11,18 @@ class AssetPathExtractor
 
     public function __construct(string $indexPath, string $buildDir, LoggerInterface $logger)
     {
+        if (!file_exists($indexPath)) {
+            return;
+        }
+
         $content = file_get_contents($indexPath);
         preg_match_all('/<script src="(.+?)" type="module"><\/script>/', $content, $matches);
         foreach ($matches[1] as $path) {
             $baseName = $this->extractBaseName($path, 'js');
             $this->javascriptFiles[$baseName] = $buildDir . $path;
         }
 
-        preg_match_all('/<link rel="stylesheet" href="(.+?)">/', $content, $matches);
+        preg_match_all('/<link rel="stylesheet" href="(.+?)"\s(\/)?>/', $content, $matches);
         foreach ($matches[1] as $path) {
             $baseName = $this->extractBaseName($path, 'css');
             $this->cssFiles[$baseName] = $buildDir . $path;

diff --git a/tests/Api/TransactionTest.php b/tests/Api/TransactionTest.php
@@ -44,17 +44,11 @@ public function testGetCollection(): void
             '@context' => '/api/contexts/Transaction',
             '@id' => '/api/transactions',
             '@type' => 'hydra:Collection',
-            'hydra:totalItems' => 100,
-            'hydra:view' => [
-                '@id' => '/api/transactions?page=1',
-                '@type' => 'hydra:PartialCollectionView',
-                'hydra:first' => '/api/transactions?page=1',
-                'hydra:last' => '/api/transactions?page=4',
-                'hydra:next' => '/api/transactions?page=2',
-            ],
+            'hydra:totalItems' => 10,
         ]);
+
         // Because test fixtures are automatically loaded between each test, you can assert on them
-        $this->assertCount(30, $response->toArray()['hydra:member']);
+        $this->assertCount(10, $response->toArray()['hydra:member']);
         // Asserts that the returned JSON is validated by the JSON Schema generated for this resource by API Platform
         // This generated JSON Schema is also used in the OpenAPI spec!
         $this->assertMatchesResourceCollectionJsonSchema(Transaction::class);

diff --git a/tests/Service/AssetPathExtractorTest.php b/tests/Service/AssetPathExtractorTest.php
@@ -0,0 +1,32 @@
+<?php
+
+namespace App\Tests\Service;
+
+use App\Service\AssetPathExtractor;
+use PHPUnit\Framework\TestCase;
+use Psr\Log\LoggerInterface;
+
+class AssetPathExtractorTest extends TestCase
+{
+    private LoggerInterface $loggerMock;
+    private string $indexPath = 'tests/mock/index.html';
+    private string $buildDir = '/build/';
+
+    protected function setUp(): void
+    {
+        $this->loggerMock = $this->createMock(LoggerInterface::class);
+    }
+
+    public function testGetScriptPath(): void
+    {
+        $extractor = new AssetPathExtractor($this->indexPath, $this->buildDir, $this->loggerMock);
+        $this->assertEquals($this->buildDir . 'runtime.abcdef.js', $extractor->getScriptPath('runtime'));
+        $this->assertEquals($this->buildDir . 'main.789012.js', $extractor->getScriptPath('main'));
+    }
+
+    public function testGetCssPath(): void
+    {
+        $extractor = new AssetPathExtractor($this->indexPath, $this->buildDir, $this->loggerMock);
+        $this->assertEquals($this->buildDir . 'styles.123456.css', $extractor->getCssPath('styles'));
+    }
+}
diff --git a/tests/mock/index.html b/tests/mock/index.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+    <head>
+        <link rel="stylesheet" href="styles.123456.css" />
+    </head>
+    <body>
+        <script src="runtime.abcdef.js" type="module"></script>
+        <script src="main.789012.js" type="module"></script>
+    </body>
+</html>