Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPI_tasks2022]: Pandora Isomemo - KernelTimeR and TimeR (~ 5 h) #8

Closed
2 tasks done
jroachell15 opened this issue Feb 28, 2022 · 17 comments
Closed
2 tasks done
Assignees

Comments

@jroachell15
Copy link
Contributor

jroachell15 commented Feb 28, 2022

Input box to select a specific time (as current in current input boxes for coordinate and zoom). Fix the current gif export bug in TimeR/KernelTimerR and add the option to export zip files containing the time slides as separate files (svg, png, pdf, tiff, geo-tiff). User options the same as with gif export but time slices as individual files (user can select jpg, tiff, png) saved in a zip file.


INWT Original Comments (August 21, 2021):

  • Input Box: ~1 h
  • Zip Export: ~4 h
    · export option will export raw data (not the plot) with resolution set by the user
    · Gif export bug: for some reason the gif export is too resource intensive for the server, which breaks the functionality; we are in the process of identifying the reason for this issue and finding a strategy to limit resource consumption.

Update (November 2, 2021): "export bug" is most probably a timeout issue on the server. Saving as separate images in zip should be quite straightforward (necessary to add zip command utility to docker image).

@jroachell15 jroachell15 changed the title [MPI_tasks2022]: KernelTimeR and TimeR (~ 5 h) [MPI_tasks2022]: Pandora Isomemo - KernelTimeR and TimeR (~ 5 h) Feb 28, 2022
@arunge
Copy link
Contributor

arunge commented Aug 9, 2022

I am checking what needs to be done still:

  • Input box to select a specific time (as current in current input boxes for coordinate and zoom).

This looks to be ready: Additionally to the slider, add an input box.
image

@isomemo Is this what you needed here?

@arunge
Copy link
Contributor

arunge commented Aug 9, 2022

It takes some time (1), but the download is working:
image

As output I got a gif (2) showing the plot for the selected steps. Seems to be fine:

image

@isomemo Do you still need the following option?

  • add the option to export zip files containing the time slides as separate files (svg, png, pdf, tiff, geo-tiff). User options the same as with gif export but time slices as individual files (user can select jpg, tiff, png) saved in a zip file.

@isomemo
Copy link
Contributor

isomemo commented Aug 9, 2022

@arunge the highlighted option in 1 is a slider (not an input box). You will notice below that we have input boxes for coordinates (to be used as an alternative to the buttons to move map/zoom slider). Please add there an input box to select time (for KernelTimerR and TimeR).

As for the bug (point 2) this was also noticed by you previously. Can you please open the gif and check if it working? I would then do my own tests.

@arunge
Copy link
Contributor

arunge commented Aug 9, 2022

Can you please open the gif and check if it working? I would then do my own tests.

The gif is working and showing (the default) 6 plots at time points 0, 1000, 2000, 3000, 4000, 5000.

@isomemo
Copy link
Contributor

isomemo commented Aug 9, 2022

@arunge I think that this worked for you because the file was small. I tried this and hte app greyed out for KernetTimeR (same happening for TimeR) before producing the gif. I did the following:

  1. Loaded the LiVES data via the IsoMemo skin
  2. Run a KernelTimeR model with lower time point as dateLower and upper time point as dateUpper
  3. The model worked fine. Then I tried to export a big between 0 and 8000 (with reverse time order) and 100 as the time interval
  4. the Generating gif time tracker ran until 0 and then the app crashed

@arunge
Copy link
Contributor

arunge commented Aug 11, 2022

New input box for the time is under review (#57).

@arunge
Copy link
Contributor

arunge commented Aug 11, 2022

I think that this worked for you because the file was small. I tried this and hte app greyed out for KernetTimeR

I can confirm this issue. The app crashed also locally for smaller time intervals. I am checking the options here.

@arunge
Copy link
Contributor

arunge commented Sep 9, 2022

@isomemo With version 22.09.01 the input box is on the beta for testing.

The zip option is under review.

@arunge
Copy link
Contributor

arunge commented Sep 21, 2022

Feedback regarding the input box

  • the update of the map is very slow
  • better use a button instead of reactive updates
  • should be executed after setting lat/lon
  • find a useful position for the button

@isomemo
Copy link
Contributor

isomemo commented Sep 21, 2022

@arunge just a small correction. The update to time should be done at the same time as for coordinates. However, if input boxes are blank previous values selected in the map remain the same. For instance, if I only input time but not coordinates nor zoom then there would be no change for the coordinates/zoom but only for time. Finally, please remember that this applies to both the TimeR and KernelTimeR models.

@arunge
Copy link
Contributor

arunge commented Sep 29, 2022

I pushed a new version 22.09.3 (with the option to download zip files) to the beta branch that will be available after tests are completed. @isomemo Feel free to test it. 🙂

I did not check this task:

  • export option will export raw data (not the plot) with resolution set by the user

Is it already there and working? Or must it be implemented?

The changes regarding

The update to time should be done at the same time as for coordinates. However, if input boxes are blank previous values selected in the map remain the same. For instance, if I only input time but not coordinates nor zoom then there would be no change for the coordinates/zoom but only for time. Finally, please remember that this applies to both the TimeR and KernelTimeR models.

are still in progress.

@arunge
Copy link
Contributor

arunge commented Oct 20, 2022

@isomemo With version 22.10.3 on the beta app I restructered the UI for zooming, lat/long (and time) in all modelling tabs. Now, one must press a button to set time, lat/long or zoom. Please, test the new UI and let me know if all works as expected.

Since, this was a more complex restructering that was necessary for all modelling tabs, this is a part of the new task "Restructure (split up) scripts for modeling tabs".


Regarding

  • export option will export raw data (not the plot) with resolution set by the user

Currently, there are buttons for

  • "Export Plot" to export jpg, pdf, svg, tiff, geo-tiff for a given width / height in pixel and
  • "Export Data" for csv, xlsx, json.

Which raw data should be exported additionally and what kind of resolution do you mean?

@isomemo
Copy link
Contributor

isomemo commented Dec 2, 2022

@arunge this should be implemented for TimeR and KernelTimeR and applies to the temporal plots. I tested this for both models using LiVES data. See images below:

image

image

The options seem correct! I suppose that "Time interval..." are the intervals at which the graphs is sampled? If so this is how it should work. The output file should include mean plus all options under estimation type in separate columns. However, when I press the button "Export" shown in figure a new tab is created but no give is given for download.

@arunge arunge assigned arunge and unassigned isomemo Dec 7, 2022
@arunge
Copy link
Contributor

arunge commented Dec 7, 2022

You are right, I tested this only with the map, which is working, but there seems to be an issue with the time plotting function.

@arunge
Copy link
Contributor

arunge commented Dec 7, 2022

I fixed the issue with version 22.12.1.
However, I am a bit confused:

  • for Map: the time series is a series of plots for a given time, exactly that time parameter which is set with the time slider, so above settings generates 6 maps for the time points 0, 1000, 2000, 3000, 4000, 5000
  • for Time course (as the example above): the time parameter is currently not used since a time plot already shows all possible time points (if I understand that correctly) -> currently a series contains always the same time course plot

I suppose that "Time interval..." are the intervals at which the graphs is sampled?

Currently the model is not recalculated to generate the series. The plot is only created dependent on the given time using the same model output.

@isomemo Should we hide this option for Time course plots? Or what kind of series should be generated in that case?
We have the time range slider here. Should somehow different time ranges be used for the time series?

@arunge arunge assigned isomemo and unassigned arunge Dec 7, 2022
@isomemo
Copy link
Contributor

isomemo commented Dec 14, 2022

@arunge when the Time course option is selected for display indeed the time parameter (in the main window) has no application. We can leave it or hide if this takes very little programming time.

@arunge
Copy link
Contributor

arunge commented Dec 20, 2022

@isomemo with version 22.12.3 on the isomemo beta app the option to create a time series in export of plots will be hidden for time course plots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants