-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quirky behaviour of setting scale ranges #27
Comments
I tested it and everything works as intended, not sure what the issue is here. When clicking on the "restrict range dependent variable" , the scale doesn't respond, yes. But why should it? You can set the scale to 0 to 0.2 and restrict the range to 0-1 (e.g. to set negative values to 0). Why should the latter change the scale. I think everything works fine here. |
Ok on TimeR working now! As you saw from the video it was not working when I tested it although now it does. Could this have been related to server overload? As for the bug with the restriction, I was referring to the endless loop that this generates. As Marcus, mentioned the restriction is a estimate option while the scale is the selected interval and I should be able to set these separately. The loop bug is shown in this video: https://www.youtube.com/watch?v=P7sfvsedfww |
@mgross @jroachell15 I will tackle the rerendering issue within #34 |
Ok! Please remember to add this to the new contract! |
Version 22.11.1 on the beta branch fixes the Bugs mentioned above. Regarding:
please note, I did not change any logic, how values are calculated. I only changed the reactive behavior. In the context of #34 I encapsulated the functionalities for the color scale into a separate module, which is now applied in all modelling tabs with the respective features, e.g.
Next, I would like to merge the current beta version into the main version. This would add all changes from version 22.09.1 on (documented here) to the main app, including Bug fixes for #62, #63, #67, #44, #27. Is that ok for you? Afterwards, I would start adding features regarding the merging of files into the beta version, such that you can test those features and that we can discuss how to implement open points regarding the merging in a future meeting. |
@arunge Yes, please merge! |
The bug is fixed, the release from beta to the main is documented in following issue: #80 |
Within AverageR and TimeR we can impose a restriction that all values must be within a certain (0-1 or 0-100). This is NOT a scale option rather it alters modelled values and constrain these within such ranges. For instance, if one applies the 0-100 restriction and the model has estimates of 105 or -3, these will be re-calculated as 100 and 0, respectively.
Separate, from the above the user can set ranges for min and max scale values. This setting is purely for visualization and does not alter modelled values. It merely sets the range for colour coding of the maps.
I was trying to generate a TimeR model using this dataset (I have used this several time before):
combined fauna2.xlsx
Model settings shown in this video (also used to report bug #28 ): https://youtu.be/_C2kZQP8PbA
While applying a constraint and then setting the colour scale the app entered a non-ending loop where it would go through various scale values. See here: https://youtu.be/P7sfvsedfww
This was an error that I reported some months ago. Prior to this the app was working as expected on the same dataset.
The text was updated successfully, but these errors were encountered: