Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quirky behaviour of setting scale ranges #27

Closed
isomemo opened this issue Apr 22, 2022 · 10 comments
Closed

Quirky behaviour of setting scale ranges #27

isomemo opened this issue Apr 22, 2022 · 10 comments
Assignees
Labels
bug Something isn't working IsoMemo App

Comments

@isomemo
Copy link
Contributor

isomemo commented Apr 22, 2022

Within AverageR and TimeR we can impose a restriction that all values must be within a certain (0-1 or 0-100). This is NOT a scale option rather it alters modelled values and constrain these within such ranges. For instance, if one applies the 0-100 restriction and the model has estimates of 105 or -3, these will be re-calculated as 100 and 0, respectively.

Separate, from the above the user can set ranges for min and max scale values. This setting is purely for visualization and does not alter modelled values. It merely sets the range for colour coding of the maps.

I was trying to generate a TimeR model using this dataset (I have used this several time before):
combined fauna2.xlsx

Model settings shown in this video (also used to report bug #28 ): https://youtu.be/_C2kZQP8PbA

While applying a constraint and then setting the colour scale the app entered a non-ending loop where it would go through various scale values. See here: https://youtu.be/P7sfvsedfww

This was an error that I reported some months ago. Prior to this the app was working as expected on the same dataset.

@isomemo isomemo added the bug Something isn't working label Apr 22, 2022
@jroachell15
Copy link
Contributor

@isomemo

Hi Ricardo,
TIMER- not working:

  • i have not been able to reproduce this: on our side, the beta version was able to upload the dataset you specified combinedFauna2, and a map was rendered. This is the result:
    image
  • could you please test this again on your end?

Scale values on the map:
image
I can confirm that when clicking the restrict range dependent variable the scale did not correspond, but when i click on from 1-100 to 0-1, then it works. We will look into this more and try to fix this.

thanks for the reporting.

@mgross
Copy link
Contributor

mgross commented May 7, 2022

I tested it and everything works as intended, not sure what the issue is here. When clicking on the "restrict range dependent variable" , the scale doesn't respond, yes. But why should it? You can set the scale to 0 to 0.2 and restrict the range to 0-1 (e.g. to set negative values to 0). Why should the latter change the scale. I think everything works fine here.

@isomemo
Copy link
Contributor Author

isomemo commented May 7, 2022

Ok on TimeR working now! As you saw from the video it was not working when I tested it although now it does. Could this have been related to server overload?

As for the bug with the restriction, I was referring to the endless loop that this generates. As Marcus, mentioned the restriction is a estimate option while the scale is the selected interval and I should be able to set these separately. The loop bug is shown in this video: https://www.youtube.com/watch?v=P7sfvsedfww

@arunge
Copy link
Contributor

arunge commented May 10, 2022

@mgross @jroachell15 I will tackle the rerendering issue within #34

@arunge
Copy link
Contributor

arunge commented Jun 15, 2022

@isomemo Since this bug is due to too many rerenderings of the map I shift it to the future tasks:
image

By restructuring the UI within #34 this bug will very certainly be fixed.

@isomemo
Copy link
Contributor Author

isomemo commented Jun 15, 2022

Ok! Please remember to add this to the new contract!

@arunge
Copy link
Contributor

arunge commented Nov 8, 2022

Version 22.11.1 on the beta branch fixes the Bugs mentioned above.

Regarding:

This is NOT a scale option rather it alters modelled values and constrain these within such ranges

please note, I did not change any logic, how values are calculated. I only changed the reactive behavior. In the context of #34 I encapsulated the functionalities for the color scale into a separate module, which is now applied in all modelling tabs with the respective features, e.g.

TimeR LocateR
image image
  • @isomemo Please, test the settings for the color scale and check if all is working as expected.

Next, I would like to merge the current beta version into the main version. This would add all changes from version 22.09.1 on (documented here) to the main app, including Bug fixes for #62, #63, #67, #44, #27. Is that ok for you?

Afterwards, I would start adding features regarding the merging of files into the beta version, such that you can test those features and that we can discuss how to implement open points regarding the merging in a future meeting.

@arunge arunge assigned isomemo and unassigned arunge Nov 8, 2022
@arunge
Copy link
Contributor

arunge commented Nov 8, 2022

Note: There are new features that you did not confirm yet (the issues are assigned to you): #8, #67, #27

Should we wait with merging those into the main app until you had the time to test them?

@isomemo
Copy link
Contributor Author

isomemo commented Dec 2, 2022

@arunge Yes, please merge!

@arunge arunge assigned arunge and unassigned isomemo Dec 2, 2022
@arunge
Copy link
Contributor

arunge commented Dec 5, 2022

The bug is fixed, the release from beta to the main is documented in following issue: #80
So, I close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working IsoMemo App
Projects
None yet
Development

No branches or pull requests

4 participants