-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile and Documentation Changes #53
Conversation
20c044d
to
8d12ce0
Compare
Empty sidebar removed by setting html_sidebar = { "***" = [] } for the included pages. Must be amended if more files are included... |
…mments, and removing unused dockerfile sections
7ceea86
to
546c466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A skim looks ok, I recomment asking @gilesknap about whether this is the best way to make the container into an actions runner. I would at least put it in a different stage so you don't get it all when you use the container as a dev container
33ecb42
to
29e1f19
Compare
29e1f19
to
e39c13b
Compare
This all looks very exciting to me! I've not looked at GitHub private runners so don't have much to add. I agree with Tom's point as far as using a separate target for the GitHub runner install bits - unfortunately this won't save you any build time for your devcontainer using podman but it will save the size of your devcontainer image. I'd like to learn more about this. For example - does the container build action work when using the IRIS runner? I thought that you could not do containers in containers there. |
Documentation:
Dockerfile: