Add PVAccess information to Table records #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does now mean we do a lot more re-ordering of the list, but the alternative is to keep two lists which would more easily become out of sync.
This applies to any PandA field that returns us a label field. Tests updated to accomodate this.
Also fixes some mypy errors in tests
Also upgrade to newest pythonSoftIoc which includes waveform of strings support. Also adjust typing of some test fixtures to better indicate that the order of items is important
Also raise exception if initial connect fails.
Also improves the IOC startup, by waiting for a signal rather than just a flat sleep timer
coretl
reviewed
May 22, 2023
Changed test to use lower case names consistent with PVA
…d the name of DummyServer to MockedServer
…e working callstack
… retrieving commands from the to give them time
…nd 3.10/3.11. We should consider 3.10 minimum on pandablocks-ioc
… give a deprecation warning on python 3.10 if you don't
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage ? 83.34%
=======================================
Files ? 7
Lines ? 1075
Branches ? 0
=======================================
Hits ? 896
Misses ? 179
Partials ? 0 ☔ View full report in Codecov by Sentry. |
…nstall requires). Should hopefully fix the problem of deprecation warnings on python/3.8
to use waits, changed the mocked_panda_standard_responses to wait until the MockedAsyncioClient is set up before proceeding with the test.
to allow bobfiles time to be written in the subprocess. Changed to pvi>=0.5 and python>=3.10
Adjust testing environment
|
@AlexanderWells-diamond Can we do this merge? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will generate the proper PVAccess information for (some) tables.
Note that this needs an in-development version of PVI, specifically the tables branch. Further additions to PVI are needed (which require fixes to Phoebus) in order to properly render Tables.
Work to do: