Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct table col name #151

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

jwlodek
Copy link
Collaborator

@jwlodek jwlodek commented Nov 13, 2024

Resolves bluesky/ophyd-async#639

Before this change:

In [10]: await panda1.data.datasets.get_value()
An exception has occurred, use '%tb verbose' to see the full traceback.
ValidationError: 1 validation error for DatasetTable
type
  Extra inputs are not permitted [type=extra_forbidden, input_value=['float64'], input_type=list]
    For further information visit https://errors.pydantic.dev/2.9/v/extra_forbidden

See /home/xf31id/.cache/bluesky/log/bluesky.log for the full traceback.

After this change:

In [11]: await test_panda.data.datasets.get_value()
Out[11]: DatasetTable(name=[], hdf5_type=[])

In [12]: await test_panda.data.datasets.get_value()
Out[12]: DatasetTable(name=['TrigTS'], hdf5_type=[<PandaHdf5DatasetType.FLOAT_64: 'float64'>])

note the second column title is just HDF5_Type, instead of just Type.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (1e1e8cd) to head (d7ac04a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   91.75%   91.67%   -0.08%     
==========================================
  Files           8        8              
  Lines        1394     1394              
  Branches      164      164              
==========================================
- Hits         1279     1278       -1     
  Misses         82       82              
- Partials       33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwlodek jwlodek merged commit a126c15 into PandABlocks:main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PandA writer fails to open, caused by issue getting dataset table
2 participants