Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit dir creation records to standard to fix PVI output #128

Merged

Conversation

jwlodek
Copy link
Collaborator

@jwlodek jwlodek commented Aug 7, 2024

When testing bluesky/ophyd-async#503 against a real PandA, I found that the PVI names for the records were not as expected. After converting to follow the other ones it works. Note the missing _ character in the structure name, and the different format of the PV name:

XF:31ID1-ES{PANDA:1}:DATA:PVI structure                                         
    structure record                                                            
        structure _options                                                      
            boolean atomic true                                                 
    structure pvi                                                               
        structure capture                                                       
            string rw XF:31ID1-ES{PANDA:1}:DATA:CAPTURE                         
        structure capture_mode                                                  
            string rw XF:31ID1-ES{PANDA:1}:DATA:CAPTURE_MODE                    
        structure createdirectory                                               
            string rw XF:31ID1-ES{PANDA:1}:DATA:CreateDirectory                 
        structure datasets                                                      
            string r XF:31ID1-ES{PANDA:1}:DATA:DATASETS                         
        structure directoryexists                                               
            string r XF:31ID1-ES{PANDA:1}:DATA:DirectoryExists                             

vs

XF:31ID1-ES{PANDA:1}:DATA:PVI structure                          
    structure record                                             
        structure _options                                       
            boolean atomic true                                  
    structure pvi                                                
        structure capture                                        
            string rw XF:31ID1-ES{PANDA:1}:DATA:CAPTURE          
        structure capture_mode                                   
            string rw XF:31ID1-ES{PANDA:1}:DATA:CAPTURE_MODE     
        structure create_directory                               
            string rw XF:31ID1-ES{PANDA:1}:DATA:CREATE_DIRECTORY 
        structure datasets                                       
            string r XF:31ID1-ES{PANDA:1}:DATA:DATASETS          
        structure directory_exists                               
            string r XF:31ID1-ES{PANDA:1}:DATA:DIRECTORY_EXISTS  

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (5309422) to head (9380d64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files           8        8           
  Lines        1378     1378           
  Branches      219      219           
=======================================
  Hits         1259     1259           
  Misses         81       81           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evalott100 evalott100 merged commit 4f9247d into PandABlocks:main Aug 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants