fixed a race condition in the table update #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalott100
force-pushed
the
fix-race-condition-in-table-update
branch
from
9aa7502
to
5813552
Compare
evalott100
force-pushed
the
fix-race-condition-in-table-update
branch
from
5813552
to
12426f6
Compare
evalott100
force-pushed
the
fix-race-condition-in-table-update
branch
from
12426f6
to
affb04a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 91.31% 91.36% +0.05%
==========================================
Files 8 8
Lines 1358 1378 +20
Branches 213 219 +6
==========================================
+ Hits 1240 1259 +19
- Misses 80 81 +1
Partials 38 38 ☔ View full report in Codecov by Sentry. |
still need to write tests trying to reproduce
still need to add a test for the race condition
evalott100
force-pushed
the
fix-race-condition-in-table-update
branch
from
5ce9c7a
to
b978e51
Compare
evalott100
force-pushed
the
fix-race-condition-in-table-update
branch
2 times, most recently
from
be105aa
to
889c6de
Compare
coretl
requested changes
Jul 2, 2024
evalott100
force-pushed
the
fix-race-condition-in-table-update
branch
from
889c6de
to
25cf4ec
Compare
coretl
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes bluesky/ophyd-async#384