Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated PandABlocks to interface with PVI 0.10.0 #132

Merged
merged 22 commits into from
Oct 2, 2024
Merged

Updated PandABlocks to interface with PVI 0.10.0 #132

merged 22 commits into from
Oct 2, 2024

Conversation

DiamondRC
Copy link
Contributor

@DiamondRC DiamondRC commented Sep 24, 2024 •
edited by evalott100
Loading

Closes #130

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (6eadee5) to head (66cdfb0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pandablocks_ioc/_pvi.py 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   91.37%   91.32%   -0.05%     
==========================================
  Files           8        8              
  Lines        1368     1372       +4     
  Branches      218      219       +1     
==========================================
+ Hits         1250     1253       +3     
- Misses         81       82       +1     
  Partials       37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evalott100 evalott100 removed their assignment Sep 25, 2024
@evalott100 evalott100 self-requested a review September 25, 2024 08:15
evalott100
evalott100 requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the prefixes.

pyproject.toml Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Show resolved Hide resolved
tests/test-bobfiles/DATA.bob Outdated Show resolved Hide resolved
@evalott100 evalott100 marked this pull request as ready for review September 25, 2024 09:17
evalott100
evalott100 requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cool, I was worried we'd have to change the mocked panda in the tests but that calls create_softioc directly.

src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/ioc.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
@evalott100
Copy link
Contributor

Interestingly the buttons on the subscreen seem to have changed to not have the name of the screen on the button. I think I prefer the new setup.

image

image

evalott100
evalott100 requested changes Sep 30, 2024
View reviewed changes
src/pandablocks_ioc/_pvi.py Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
evalott100
evalott100 requested changes Sep 30, 2024
View reviewed changes
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
evalott100
evalott100 requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing.

We should double check everything is looking normal on the phoebus screens for the ioc too.

src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
evalott100
evalott100 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@evalott100 evalott100 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerun ruff and this should automatically fix, then we're good to merge. (But please squash your commits).

src/pandablocks_ioc/_hdf_ioc.py Outdated Show resolved Hide resolved
@DiamondRC DiamondRC merged commit c4dea92 into main Oct 2, 2024
20 checks passed
@evalott100 evalott100 deleted the update_PVI branch October 7, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evalott100 evalott100 evalott100 approved these changes

Assignees

@DiamondRC DiamondRC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to pvi version 0.10.0
2 participants
@DiamondRC @evalott100