Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated PandABlocks to interface with PVI 0.10.0 #132

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updated PandABlocks to interface with PVI 0.10.0 #132

wants to merge 4 commits into from

Conversation

DiamondRC
Copy link

@DiamondRC DiamondRC commented Sep 24, 2024 •
edited by evalott100
Loading

Closes #130

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (6eadee5) to head (192b95d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files           8        8           
  Lines        1368     1368           
  Branches      218      218           
=======================================
  Hits         1250     1250           
  Misses         81       81           
  Partials       37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evalott100 evalott100 removed their assignment Sep 25, 2024
@evalott100 evalott100 self-requested a review September 25, 2024 08:15
evalott100
evalott100 requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the prefixes.

pyproject.toml Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
src/pandablocks_ioc/_pvi.py Show resolved Hide resolved
tests/test-bobfiles/DATA.bob Show resolved Hide resolved
@evalott100 evalott100 marked this pull request as ready for review September 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evalott100 evalott100 evalott100 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@DiamondRC DiamondRC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to pvi version 0.10.0
2 participants
@DiamondRC @evalott100